loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,009 Commits 1 Branch 0 Tags
Commit Graph

679 Commits

Author SHA1 Message Date
insun
7228b2d718 Show overflow button only when there is no enough space 
Previously, the overflow button was always shown at the bottom in StyledPlayerControlView
and hided the settings cog even when there is enough space.

With this change, the settings cog moves out from overflow and
the overflow button is shown only when the buttom space is not enough.

PiperOrigin-RevId: 336029179
 2020-10-13 16:27:00 +01:00
andrewlewis
ac782235ca Fix miscellaneous nits/typos 
PiperOrigin-RevId: 335642909
 2020-10-06 16:57:31 +00:00
samrobinson
a552e35f6a Add getter and callbacks for static metadata retrieval. 
Issue:#7266
PiperOrigin-RevId: 335416280
 2020-10-06 14:31:32 +01:00
samrobinson
c95e43d9bd Do not require subtitleButton in custom layouts of StyledPlayerView 
Every other subtitleButton has an if not null check, but does not force non null.

Issue: #7962
PiperOrigin-RevId: 334124323
 2020-09-30 11:55:18 +01:00
Oliver Woodman
19a0258bac Merge pull request #7798 from yoobi:trackSelectionView 
PiperOrigin-RevId: 333751261
 2020-09-25 17:49:12 +01:00
bachinger
ea57e5d28b Always pass true for ongoing with the first notification 
ISSUE: #7977
PiperOrigin-RevId: 333726625
 2020-09-25 16:34:37 +01:00
olly
cef3e3cac1 Cleanup layout XMLs to be consistent with others 
PiperOrigin-RevId: 333023580
 2020-09-25 16:29:25 +01:00
olly
f16f8e59ff Replace duration strings with plurals 
PiperOrigin-RevId: 332014290
 2020-09-16 17:00:42 +01:00
olly
cdcb30ed21 Exclude Guava transitive annotation dependencies 
PiperOrigin-RevId: 331148067
 2020-09-11 16:01:15 +01:00
insun
222ba22b10 Fix not to show repeat button when its mode is NONE. 
PiperOrigin-RevId: 330627047
 2020-09-09 09:42:00 +01:00
insun
ea158dcdb0 Apply styled widget's bug fixes to legacy widget 
- Prevent buffering when clicking ffwd button at the end of stream
- Set VR button disabled when listener is not registered

PiperOrigin-RevId: 330039336
 2020-09-07 20:43:10 +01:00
insun
f68faff30b Set VR button disabled when listener is not registered (styled view) 
PiperOrigin-RevId: 329851964
 2020-09-07 20:42:33 +01:00
olly
b5a4dc8f36 Fix dispatch of play when in IDLE or ENDED 
PiperOrigin-RevId: 329722282
 2020-09-07 20:42:04 +01:00
insun
f31411b128 Revise Play/Pause button toggling logic 
This CL fixes two bugs:
- Play/pause button toggling looked inconsistent when playback fails.
  When player state goes into idle, play button should dispatch
  playwhenready again.
- Clicking play button at the end of stream should restart playback.
  But previously it changed playwhenready state and so playback has
  been paused. This CL fix it.

PiperOrigin-RevId: 329675660
 2020-09-07 20:41:27 +01:00
insun
be103ac553 Add padding to styled widget's settings items 
PiperOrigin-RevId: 329671522
 2020-09-07 20:41:18 +01:00
olly
5c24d1ccea Clean up unnecessary use of full package name 
PiperOrigin-RevId: 329666401
 2020-09-07 20:41:09 +01:00
insun
f68fc3e701 Prevent buffering when clicking ffwd button at the end of stream 
PiperOrigin-RevId: 329634001
 2020-09-07 20:40:32 +01:00
bachinger
0045d20d2c Document how to set the priority on API level above 25 
Issue: #7820
PiperOrigin-RevId: 328917063
 2020-09-07 20:39:08 +01:00
bachinger
8a8a1517ec Handle KEYCODE_HEADSETHOOK as alias of KEYCODE_MEDIA_PLAY_PAUSE 
ISSUE: #7813
PiperOrigin-RevId: 328910220
 2020-09-07 20:38:59 +01:00
Yo Ob
869981a360
Merge branch 'dev-v2' into trackSelectionView 2020-08-28 11:36:59 +02:00
tonihei
237cb9df54 Merge pull request #7804 from yoobi:TrackSelectionDialogBuilderTheme 
PiperOrigin-RevId: 328726246
 2020-08-27 14:41:28 +00:00
andrewlewis
74c493f51e Add back support for setting audio pitch 
To play slow motion streams where the audio has been recorded at
slower speeds, it is necessary to be able to resample (rather than
time-stretch) the audio. This change undeprecates back the previously
deprecated PlaybackParameters class to allow apps to set pitch.

PiperOrigin-RevId: 328703116
 2020-08-27 12:06:41 +01:00
Yoni Obadia
c9b4b98103 Review: Fix initSortedTrack to keep all groups in the TrackGroupArray 2020-08-27 12:19:56 +02:00
Yoni Obadia
551b6d65ae Review: Simplify getSortedIndexFromInitialTrackGroup 2020-08-27 10:15:17 +02:00
Yoni Obadia
ed58280d23 Review: Update according to review 2020-08-27 09:46:30 +02:00
Yoni Obadia
0176422f0b Review: Update according to review 2020-08-26 19:07:47 +02:00
Yoni Obadia
425bd2d801 improvement: get already existing sortingTrackGroups if exists 2020-08-26 14:31:44 +02:00
Yoni Obadia
88d7587ca7 dev: add setting theme for TrackSelectionDialogBuilder 2020-08-26 11:40:48 +02:00
Yoni Obadia
181676d950 dev: adding sorting for TrackSelectionDialog and TrackSelectionDialogBuilder 2020-08-24 15:13:21 +02:00
insun
74f788afc3 Improve a11y in minimal mode 
Previously, the fullscreen button and timebar has been overlapped in minimal mode

PiperOrigin-RevId: 327606728
 2020-08-21 12:51:15 +01:00
insun
b853978a91 Fix bug to show 'play' button at the end of stream 
PiperOrigin-RevId: 327158791
 2020-08-18 08:11:54 +01:00
insun
333ccedf80 Improve error message and correct reference to proper layout 
PiperOrigin-RevId: 326944292
 2020-08-17 16:13:43 +01:00
insun
602d880841 Fix StyledControlView's minimal mode bug and setShow{*}Button bug 
There were two bugs in StyledPlayerControlView:
- Center icons are shown when toggling control view in minimal mode.
- `StyledControlView#setShow{*}Button` methods and corresponding
  `set_show_*_button` attributes didn't work properly.

This CL fixes bugs by controlling the buttons' visibility in one place,
StyledPlayerControlViewLayoutManager.

PiperOrigin-RevId: 326567213
 2020-08-17 16:12:30 +01:00
insun
454a38c366 Increase touch target size and margins between icons 
PiperOrigin-RevId: 326423935
 2020-08-17 16:11:44 +01:00
insun
cda35f6677 Make play/pause button to reflect getPlayWhenReady state 
Previously, it refelects isPlaying() and it makes the button to seem
unresponsive when playback error occurs.

PiperOrigin-RevId: 326396570
 2020-08-17 16:10:59 +01:00
insun
b95c984d16 Cleanup unused ui resources and code 
PiperOrigin-RevId: 326390725
 2020-08-17 16:10:40 +01:00
insun
8661876960 Remove unnessary resources 
1) As we don't display metadata (title) removed titlebar.
2) Removed exo_ic_{forward,rewind}_30.xml which are not used.

PiperOrigin-RevId: 325195605
 2020-08-07 19:01:55 +01:00
insun
b26d578ff3 Fix bug that clicking didn't show up controls at the beginning 
StyledLayoutManager#isFullyVisibility() was wrong and
so hiding/showing logic didn't work properly.

PiperOrigin-RevId: 324996446
 2020-08-07 19:01:45 +01:00
olly
5c879ac8f8 Final string import for 2.12 
PiperOrigin-RevId: 324579230
 2020-08-07 18:58:51 +01:00
insun
f99023e887 Makes controls initially hidden 
Also, there was a bug that controls are always shown at the beginning
even when controlview's hide() is called.

PiperOrigin-RevId: 323300617
 2020-07-27 23:59:16 +01:00
insun
6fb28a8dc9 Hide fullscreen button if no listener is registered 
PiperOrigin-RevId: 322912266
 2020-07-24 10:48:43 +01:00
insun
cf2a58e6dc Fix styled ui's documents 
#exofixit

PiperOrigin-RevId: 322854029
 2020-07-24 10:48:25 +01:00
olly
132c9d15e3 UI module string cleanup 
PiperOrigin-RevId: 322323784
 2020-07-24 10:43:07 +01:00
olly
899a78fca9 StyledPlayerControlView: Some cleanup 
PiperOrigin-RevId: 322317638
 2020-07-24 10:42:48 +01:00
insun
63ca2b00fb Resolve styled controls crash on pre-API 21 
When building a demo app without recent gradle (ex. blaze)
it crashes.

PiperOrigin-RevId: 322313886
 2020-07-24 10:42:39 +01:00
andrewlewis
9594aa45ff Move functionality from DemoApplication to DemoUtil 
https://developer.android.com/reference/android/app/Application recommends
against subclassing application.

PiperOrigin-RevId: 322163812
 2020-07-24 10:41:27 +01:00
olly
0cd15d9158 Proactively check listener arguments are non-null 
PiperOrigin-RevId: 322143359
 2020-07-24 10:40:24 +01:00
tonihei
953db7898e Make dependency on AndroidX appcompat optional for dialog builder. 
The dependency is only used to create a dialog in
TrackSelectionDialogBuilder that is compatible with newer styling
options.

This dependendy adds over 500Kb to the apk (even if unused) and we
shoudn't force this on an app. Instead make the dependency optional by
automatically falling back to the platform version if the AndroidX one
doesn't exist.

Issue: #7357
PiperOrigin-RevId: 322143005
 2020-07-24 10:40:15 +01:00
insun
bcf218da60 Import translated strings 
PiperOrigin-RevId: 321762840
 2020-07-24 10:38:08 +01:00
ibaker
437d1b6e9a Migrate usages of deprecated Player#set/getPlaybackParameters() 
PiperOrigin-RevId: 321166822
 2020-07-24 10:33:36 +01:00