ibaker
a6358dc7be
Escape the rubyText when generating HTML
...
This should have been done before, I just missed it.
PiperOrigin-RevId: 304612519
2020-04-06 13:27:58 +01:00
ibaker
6438e1cdbc
Add support for tate-chu-yoko to SpannedToHtmlConverter
...
PiperOrigin-RevId: 304386857
2020-04-06 13:27:27 +01:00
ibaker
205adb7f8d
Rewrite the vertical text support in SubtitleWebView
...
The attempt in <unknown commit> was hacky and incomplete.
PiperOrigin-RevId: 304356038
2020-04-06 13:27:06 +01:00
ibaker
7323b5351a
Add support for multi-line strings to SpannedToHtmlConverter
...
PiperOrigin-RevId: 304355717
2020-04-06 13:26:50 +01:00
ibaker
262f19aa63
Add vertical text support to SubtitleWebView
...
PiperOrigin-RevId: 304186326
2020-04-01 22:38:54 +01:00
ibaker
76358d983f
Base64 encode the subtitle HTML before passing to WebView.loadData
...
Without this, URL-encoding is assumed, which means ampersand-codes are
not carried through to the underlying web page correctly.
PiperOrigin-RevId: 304163733
2020-04-01 22:38:27 +01:00
ibaker
5392a2f4bc
Add non-ascii characters to SpannedToHtmlConverterTest
...
These are handled by converting to ampersand codes - add a test to show
that's explicit & deliberate.
PiperOrigin-RevId: 304163712
2020-04-01 22:38:19 +01:00
ibaker
802d71a5cb
Add cue positioning to SubtitleWebView
...
PiperOrigin-RevId: 303998690
2020-04-01 22:37:33 +01:00
jaewan
a2896c6cba
Allow developers to specify CharSequence for Notification strings
...
CharSequence is used by Notification builders and allows to set Spannable text.
It's the base interface of the String class, so apps wouldn't be break after
the update.
PiperOrigin-RevId: 303731890
2020-03-30 17:17:27 +01:00
ibaker
92494ce44b
Document that overlapping spans aren't rendered to HTML correctly
...
Add some mitigation about why this is probably on OK limitation.
PiperOrigin-RevId: 302907940
2020-03-27 23:30:28 +00:00
andrewlewis
26a27944c5
Add option for sensor rotation in 360 playbacks
...
Issue: #6761
PiperOrigin-RevId: 300715682
2020-03-19 00:47:12 +00:00
bachinger
527563da31
remove deprecated usage of PlaybackParameter
...
Removes usage of PlaybackParameters where it seems to be trivial.
PiperOrigin-RevId: 300435199
2020-03-19 00:45:18 +00:00
olly
f82bc244ea
Add show/hideScrubber to DefaultTimeBar
...
PiperOrigin-RevId: 300249371
2020-03-11 16:27:07 +00:00
olly
b83041a6f5
Fix SubtitleView.ViewType IntDef
...
PiperOrigin-RevId: 300067502
2020-03-11 16:26:33 +00:00
tonihei
b5976a55ff
Upgrade Kotlin annotations and fix gradle warnings
...
The new version fixes some warnings in Gradle builds. Also
add missing indirect compileOnly dependencies to fix some more warnings
Issue:issue:#7007
PiperOrigin-RevId: 298855510
2020-03-10 10:19:19 +00:00
ibaker
63256a48d4
Disable text selection in SubtitleWebView
...
PiperOrigin-RevId: 298605366
2020-03-10 10:17:56 +00:00
ibaker
7bfd2b27eb
Start generating HTML from Span-styling in SubtitleWebView
...
PiperOrigin-RevId: 298565231
2020-03-10 10:17:39 +00:00
olly
a6d0caaa3c
Drop prefix test- from test methods under v2/library
...
This is one step toward following the google3's test naming convention.
See go/java-testing/getting_started#basic-test-template for details
why prefix test isn't necessary.
This CL is generated by following command
$ find -name '*Test.java' | xargs -I{} sed -i 's/^\ \ public\ void\ test\([A-Z]\)\(.*\)$/ public void \L\1\E\2/' {}
and then manually modified following tests where test method names conflict with test target.
- VorbisUtilTest
- VorbisReaderTest
- UtilTest
- DownloadManagerDashTest
- DefaultOggSeekerTest
- OggPageHeaderTest
- HlsMasterPlaylistParserTest
PiperOrigin-RevId: 298074653
2020-03-10 10:15:43 +00:00
olly
54283746be
Fix lint errors
...
PiperOrigin-RevId: 295953956
2020-02-25 21:21:29 +00:00
christosts
0a612ce34a
Video processing offset in AnalyticsListener
...
PiperOrigin-RevId: 295146481
2020-02-17 17:13:09 +00:00
christosts
9c58e57127
Video frame processing offset in DecoderCounters
...
Add fields in DecoderCounters for computing the average video frame
processing offset.
The MediaCodecVideoRenderer reports the video frame processing offset
and the demo app presents it on the debug information.
PiperOrigin-RevId: 294677878
2020-02-13 15:45:22 +00:00
olly
1440cad5ed
Fix build warnings under exoplayer/v2/library
...
- Removes empty <p> tag in javadoc
- Removes incorrect parameter name warnings for var args.
PiperOrigin-RevId: 294555651
2020-02-13 15:44:11 +00:00
olly
12187c9048
Apply minimal layout change according to view size
...
- Add method to scale scrubber handle of DefaultTimeBar
PiperOrigin-RevId: 294366734
2020-02-11 17:12:29 +00:00
bachinger
3dc9225bab
remove deprecated usage of onPlayerStateChanged in ui components
...
PiperOrigin-RevId: 294182858
2020-02-11 17:11:11 +00:00
bachinger
c02933ac0a
rename getPlaybackError
...
PiperOrigin-RevId: 294074348
2020-02-11 17:10:41 +00:00
bachinger
e1c48515eb
add next, previous, fastForward and rewind to ControlDispatcher
...
Issue: #6926 , #6934
PiperOrigin-RevId: 293315532
2020-02-11 17:07:52 +00:00
bachinger
4bb6036cf6
add playback state changed listener
...
This change deprecates Player.onPlayerStateChanged(boolean pwr, int state). It removes deprecation for trivial cases. I'll remove other deprecated usages (mostly in ui module) in follow-up CLs to not bloat this CL.
PiperOrigin-RevId: 292917872
2020-02-11 17:07:03 +00:00
ibaker
b6bd57ab12
Replace most usages of @TargetApi with @RequiresApi
...
We keep @TargetApi where the method is a safe no-op on
older versions due to an in-line version check.
PiperOrigin-RevId: 292878727
2020-02-03 11:21:21 +00:00
ibaker
c7ea8bbf1a
Reduce the number of allocations in SubtitlePainter.setupTextLayout
...
PiperOrigin-RevId: 292877661
2020-02-03 11:21:05 +00:00
Oliver Woodman
cf06589029
Merge pull request #6724 from nnoury:fix/subtitles-outline-color
...
PiperOrigin-RevId: 292316767
2020-01-30 19:30:48 +00:00
ibaker
e15989ffff
Add @Dimension annotation to SubtitleView size methods
...
PiperOrigin-RevId: 291943185
2020-01-30 19:29:38 +00:00
ibaker
658e0e17b8
Make SubtitleWebView 'invisible' to touch events
...
Without this, tapping the main video playback doesn't bring up the
controls.
PiperOrigin-RevId: 291943063
2020-01-30 19:29:29 +00:00
Nicolas Noury
1e72e1acff
Introduce edgeLayout to keep outline color
...
Fix outline style subtitle
When a ForegroundColorSpan changes the foreground color, it is also applied
to the outline painter. In order to keep the correct color, one needs to
filter out theses span. We do this with a new cue that is our text source
for the specific edgeLayout.
Take care to only apply background color once
Test: Manual check - Subtitle view can show custom color subtitles from specific Subtitle
Renderer and outline is shown correctly using user defined color.
2020-01-29 14:48:06 +01:00
krocard
e92ea31fcd
Do not throw on valid SubtitleView.setViewType
...
Calling setViewType with the same view type as the
subtitleView is using would throw InvalidArgumentException
instead of being a noop.
PiperOrigin-RevId: 291937202
2020-01-28 16:57:01 +00:00
ibaker
2fd8cf0206
Add SubtitleWebView
...
PiperOrigin-RevId: 291927263
2020-01-28 16:56:51 +00:00
ibaker
f3157e703f
Split some of SubtitleView out into SubtitleTextView
...
SubtitleView now becomes a ViewGroup that owns a SubtitleTextView. It
handles some common styling defaults, but delegates the underlying
values down into SubtitleTextView through the SubtitleView.Output
interface.
When I add a SubtitleWebView this will also be a ViewGroup containing
a WebView and will implement SubtitleView.Output and convert Cue styling
into HTML & CSS.
PiperOrigin-RevId: 291903294
2020-01-28 16:56:17 +00:00
olly
a225e887fa
Move @MonotonicNonNull annotations to their correct positions
...
PiperOrigin-RevId: 289823804
2020-01-16 13:51:09 +00:00
tonihei
216518eb0e
Disable chronometer for playback speeds != 1.0
...
This doesn't work because the Chronometer text layout can only count in realtime.
Issue:#6816
PiperOrigin-RevId: 288711702
2020-01-08 22:15:35 +00:00
andrewlewis
b5fa338367
Show ad markers after the window duration
...
Issue: #6552
PiperOrigin-RevId: 287964221
2020-01-06 14:54:16 +00:00
olly
2380f937f3
Document overriding of drawables for PlayerControlView
...
Issue: #6779
PiperOrigin-RevId: 287828273
2020-01-02 19:24:15 +00:00
olly
a3bad3680b
Document overriding drawables for notifications
...
Issue: #6266
PiperOrigin-RevId: 287821640
2020-01-02 19:24:07 +00:00
ibaker
9ec524a7e2
Rollback of 355ed11a3c
...
*** Original commit ***
Suppress warnings emitted by Checker Framework version 2.11.1
More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:278915274:BASE:278884711:1573074344615:a6701677
***
PiperOrigin-RevId: 284741721
2019-12-10 12:37:42 +00:00
ibaker
3233995441
Rollback of 4fd881a551
...
*** Original commit ***
Suppress warnings emitted by Checker Framework version 3.0.0
More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:279845168:BASE:279870402:1573537714395:80ca701c
***
PiperOrigin-RevId: 284740695
2019-12-10 12:37:34 +00:00
ibaker
4c4cabdfac
(partial) Rollback of 880b879e8c
...
*** Original commit ***
Suppress warnings emitted by Checker Framework version 2.11.1
More information:
https://docs.google.com/document/d/16tpK6aXqN68PvTyvt4siM-m7f0NXi_8xEeitLDzr8xY/edit?usp=sharing
Tested:
TAP train for global presubmit queue
http://test/OCL:278152710:BASE:278144052:1572760370662:22459c12
***
PiperOrigin-RevId: 284738438
2019-12-10 12:37:26 +00:00
olly
90329a14c3
Make DefaultTimeBar exclude itself for gestures
...
Issue: #6685
PiperOrigin-RevId: 284736041
2019-12-10 12:37:18 +00:00
tonihei
72d5b425d3
Add IntDefs for renderer capabilities.
...
This simplifies documentation and adds compiler checks that the correct values
are used.
PiperOrigin-RevId: 283754163
2019-12-05 10:20:15 +00:00
bachinger
bab8975438
reduce number of notification updates
...
Issue: #6657
PiperOrigin-RevId: 283563218
2019-12-04 10:00:30 +00:00
andrewlewis
4f37d28eb1
Fix typo in DefaultTimeBar javadoc
...
PiperOrigin-RevId: 283515315
2019-12-04 09:59:24 +00:00
olly
6c65c27e9b
Remove nullness blacklist for UI module
...
PiperOrigin-RevId: 283324784
2019-12-04 09:58:53 +00:00
olly
b68d19bceb
Add layer of indirection for drawables
...
This allows easy overriding of the resources by app developers
Issue: #6709
PiperOrigin-RevId: 283306121
2019-12-04 09:58:20 +00:00