From f5d3900b6db349d96935393a6bbc28a5cb0653b0 Mon Sep 17 00:00:00 2001 From: bachinger Date: Tue, 23 Nov 2021 00:35:16 +0000 Subject: [PATCH] Document that channelNameResourceId needs to be set This is documented on the setter already, but it seems to make sense to do this in the constructor as well for clarity. Issue: google/ExoPlayer#9550 PiperOrigin-RevId: 411675700 --- .../java/androidx/media3/ui/PlayerNotificationManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/ui/src/main/java/androidx/media3/ui/PlayerNotificationManager.java b/libraries/ui/src/main/java/androidx/media3/ui/PlayerNotificationManager.java index b56e465418..8909d3d400 100644 --- a/libraries/ui/src/main/java/androidx/media3/ui/PlayerNotificationManager.java +++ b/libraries/ui/src/main/java/androidx/media3/ui/PlayerNotificationManager.java @@ -345,7 +345,9 @@ public class PlayerNotificationManager { * * @param context The {@link Context}. * @param notificationId The id of the notification to be posted. Must be greater than 0. - * @param channelId The id of the notification channel. + * @param channelId The id of the notification channel of an existing notification channel or of + * the channel that should be automatically created. In the latter case, {@link + * #setChannelNameResourceId(int)} needs to be called as well. */ public Builder(Context context, @IntRange(from = 1) int notificationId, String channelId) { checkArgument(notificationId > 0);