From f3c7c88d7c4fd4ad5edca62c75a3193477617aa0 Mon Sep 17 00:00:00 2001 From: ibaker Date: Thu, 2 Apr 2020 10:00:33 +0100 Subject: [PATCH] Tweak Cue.line javadoc again to reflect WebVTT spec It's interesting WebVTT explicitly handles line & position differently in horizontal-rl/lr and vertical-lr/rl contexts. position is always measured from the left of the viewport, even for rtl text, but line in vertical-rl is measured from the right of the viewport. We don't have to make Cue match WebVTT (I can go change the WebVTT decoding instead) but it seems a reasonable 'default' to follow. PiperOrigin-RevId: 304353900 --- .../main/java/com/google/android/exoplayer2/text/Cue.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/text/Cue.java b/library/core/src/main/java/com/google/android/exoplayer2/text/Cue.java index 171ebc007d..e63bf574a8 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/text/Cue.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/text/Cue.java @@ -154,9 +154,10 @@ public final class Cue { * */ public final float line;