loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable frame dropping on sm-x200@API34

Browse Source 
From debug trace when decoding a 30fps video, the decoder output

```
"0us",
"33366us",
"66733us",
"100100us",
"133466us",
"166833us",
"200200us",
```

But the frame processor only received, despite setting `ALLOW_FRAME_DROP`:

```
"0us",
"166833us",
"200200us",
```

PiperOrigin-RevId: 658079749
This commit is contained in:
claincly 2024-07-31 11:27:38 -07:00 committed by Copybara-Service
parent dc3a9cea3e
commit f3bf4ad5fe
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libraries/common/src/main/java/androidx/media3/common/util/Util.java
View File

@ -3371,13 +3371,14 @@ public final class Util {
// bounds. From API 29, if the app targets API 29 or later, the {@link // bounds. From API 29, if the app targets API 29 or later, the {@link
// MediaFormat#KEY_ALLOW_FRAME_DROP} key prevents frame dropping even when the surface is // MediaFormat#KEY_ALLOW_FRAME_DROP} key prevents frame dropping even when the surface is
// full. // full.
// Some API 30 devices might drop frames despite setting {@link // Some devices might drop frames despite setting {@link
// MediaFormat#KEY_ALLOW_FRAME_DROP} to 0. See b/307518793 and b/289983935. // MediaFormat#KEY_ALLOW_FRAME_DROP} to 0. See b/307518793, b/289983935 and b/353487886.
return SDK_INT < 29 return SDK_INT < 29
|| context.getApplicationInfo().targetSdkVersion < 29 || context.getApplicationInfo().targetSdkVersion < 29
|| (SDK_INT == 30 || (SDK_INT == 30
&& (Ascii.equalsIgnoreCase(MODEL, "moto g(20)") && (Ascii.equalsIgnoreCase(MODEL, "moto g(20)")
|| Ascii.equalsIgnoreCase(MODEL, "rmx3231"))); || Ascii.equalsIgnoreCase(MODEL, "rmx3231"))
|| (SDK_INT == 34 && Ascii.equalsIgnoreCase(MODEL, "sm-x200")));
} }
/** /**