loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add getMinimumLoadableRetryCount to LoadErrorHandlingPolicy.

Browse Source 
This will allow deduplicating the argument from all Loader clients.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204889331
This commit is contained in:
aquilescanta 2018-07-17 03:53:55 -07:00 committed by Oliver Woodman
parent 6aab2bdc55
commit f155aa2563
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
library/core/src/main/java/com/google/android/exoplayer2/upstream/LoadErrorHandlingPolicy.java
View File

@ -19,6 +19,7 @@ import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.ParserException; import com.google.android.exoplayer2.ParserException;
import com.google.android.exoplayer2.source.chunk.ChunkedTrackBlacklistUtil; import com.google.android.exoplayer2.source.chunk.ChunkedTrackBlacklistUtil;
import com.google.android.exoplayer2.upstream.HttpDataSource.InvalidResponseCodeException; import com.google.android.exoplayer2.upstream.HttpDataSource.InvalidResponseCodeException;
import com.google.android.exoplayer2.upstream.Loader.Callback;
import com.google.android.exoplayer2.upstream.Loader.Loadable; import com.google.android.exoplayer2.upstream.Loader.Loadable;
import java.io.IOException; import java.io.IOException;
@ -32,13 +33,17 @@ import java.io.IOException;
* blacklisted. Blacklisting will succeed if any of the alternatives is not in the black list. * blacklisted. Blacklisting will succeed if any of the alternatives is not in the black list.
* *
* <p>When blacklisting does not take place, {@link #getRetryDelayMsFor(T, long, IOException, int)} * <p>When blacklisting does not take place, {@link #getRetryDelayMsFor(T, long, IOException, int)}
* defines whether the load is retried. Loader clients define when to propagate retry attempt * defines whether the load is retried. Errors whose load is not retried are propagated. Load errors
* errors. Errors that are not retried are propagated. * whose load is retried are propagated according to {@link
* #getMinimumLoadableRetryCount(Loadable)}.
* *
* @param <T> The type of the object being loaded. * @param <T> The type of the object being loaded.
*/ */
public interface LoadErrorHandlingPolicy<T extends Loadable> { public interface LoadErrorHandlingPolicy<T extends Loadable> {
/** The default minimum number of times to retry loading data prior to propagating the error. */
int DEFAULT_MIN_LOADABLE_RETRY_COUNT = 3;
/** Default implementation of {@link LoadErrorHandlingPolicy}. */ /** Default implementation of {@link LoadErrorHandlingPolicy}. */
LoadErrorHandlingPolicy<Loadable> DEFAULT = LoadErrorHandlingPolicy<Loadable> DEFAULT =
new LoadErrorHandlingPolicy<Loadable>() { new LoadErrorHandlingPolicy<Loadable>() {
@ -72,6 +77,12 @@ public interface LoadErrorHandlingPolicy<T extends Loadable> {
? C.TIME_UNSET ? C.TIME_UNSET
: Math.min((errorCount - 1) * 1000, 5000); : Math.min((errorCount - 1) * 1000, 5000);
} }
/** Returns {@link #DEFAULT_MIN_LOADABLE_RETRY_COUNT}. */
@Override
public int getMinimumLoadableRetryCount(Loadable loadable) {
return DEFAULT_MIN_LOADABLE_RETRY_COUNT;
}
}; };
/** Returns {@link #DEFAULT}. */ /** Returns {@link #DEFAULT}. */
@ -113,4 +124,15 @@ public interface LoadErrorHandlingPolicy<T extends Loadable> {
* C#TIME_UNSET} if the error is fatal and should not be retried. * C#TIME_UNSET} if the error is fatal and should not be retried.
*/ */
long getRetryDelayMsFor(T loadable, long loadDurationMs, IOException exception, int errorCount); long getRetryDelayMsFor(T loadable, long loadDurationMs, IOException exception, int errorCount);
/**
* Returns the minimum number of times to retry a load in the case of a load error, before
* propagating the error.
*
* @param loadable The loadable to load.
* @return The minimum number of times to retry a load in the case of a load error, before
* propagating the error.
* @see Loader#startLoading(Loadable, Callback, int)
*/
int getMinimumLoadableRetryCount(T loadable);
} }