diff --git a/libraries/common/src/main/java/androidx/media3/common/ColorInfo.java b/libraries/common/src/main/java/androidx/media3/common/ColorInfo.java index 92906d75a7..c0b0803f3a 100644 --- a/libraries/common/src/main/java/androidx/media3/common/ColorInfo.java +++ b/libraries/common/src/main/java/androidx/media3/common/ColorInfo.java @@ -288,10 +288,10 @@ public final class ColorInfo implements Bundleable { /** * Returns whether this instance is valid. * - *

This instance is valid if at least one between bitdepths and color info are valid. + *

This instance is valid if at least one between bitdepths and DataSpace info are valid. */ public boolean isValid() { - return isBitdepthValid() || isColorValid(); + return isBitdepthValid() || isDataSpaceValid(); } /** @@ -304,11 +304,11 @@ public final class ColorInfo implements Bundleable { } /** - * Returns whether this instance is color valid. + * Returns whether this instance has valid DataSpace members. * - *

This instance is valid if no color members are {@link Format#NO_VALUE}. + *

This instance is valid if no DataSpace members are {@link Format#NO_VALUE}. */ - public boolean isColorValid() { + public boolean isDataSpaceValid() { return colorSpace != Format.NO_VALUE && colorRange != Format.NO_VALUE && colorTransfer != Format.NO_VALUE; @@ -325,11 +325,11 @@ public final class ColorInfo implements Bundleable { } String bitdepthsString = isBitdepthValid() ? lumaBitdepth + "/" + chromaBitdepth : "NA"; - String colorString = isColorValid() ? Util.formatInvariant("%s/%s/%s", + String dataspaceString = isDataSpaceValid() ? Util.formatInvariant("%s/%s/%s", colorSpaceToString(colorSpace), colorRangeToString(colorRange), colorTransferToString(colorTransfer)) : "NA"; - return bitdepthsString + "/" + colorString; + return bitdepthsString + "/" + dataspaceString; } @Override diff --git a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java index 16bc873e6e..8a00c8ca7a 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java @@ -253,9 +253,9 @@ public final class DefaultVideoFrameProcessor implements VideoFrameProcessor { throws VideoFrameProcessingException { // TODO(b/261188041) Add tests to verify the Listener is invoked on the given Executor. - checkArgument(inputColorInfo.isColorValid()); + checkArgument(inputColorInfo.isDataSpaceValid()); checkArgument(inputColorInfo.colorTransfer != C.COLOR_TRANSFER_LINEAR); - checkArgument(outputColorInfo.isColorValid()); + checkArgument(outputColorInfo.isDataSpaceValid()); checkArgument(outputColorInfo.colorTransfer != C.COLOR_TRANSFER_LINEAR); if (ColorInfo.isTransferHdr(inputColorInfo) || ColorInfo.isTransferHdr(outputColorInfo)) { checkArgument(enableColorTransfers); diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSampleExporter.java b/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSampleExporter.java index 27eb34d2d4..7be4235563 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSampleExporter.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/VideoSampleExporter.java @@ -97,7 +97,7 @@ import org.checkerframework.dataflow.qual.Pure; finalFramePresentationTimeUs = C.TIME_UNSET; ColorInfo decoderInputColor; - if (firstInputFormat.colorInfo == null || !firstInputFormat.colorInfo.isColorValid()) { + if (firstInputFormat.colorInfo == null || !firstInputFormat.colorInfo.isDataSpaceValid()) { Log.d(TAG, "colorInfo is null or invalid. Defaulting to SDR_BT709_LIMITED."); decoderInputColor = ColorInfo.SDR_BT709_LIMITED; } else {