loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use List in createRenderers for better readability

Browse Source 
Also Use `Iterables.toArray()` to void the confusing `List.toArray()` method call

PiperOrigin-RevId: 634351844
This commit is contained in:
claincly 2024-05-16 06:02:29 -07:00 committed by Copybara-Service
parent 7b2a1b4443
commit f0e420e101
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
libraries/transformer/src/main/java/androidx/media3/transformer/ExoPlayerAssetLoader.java
View File

@ -55,6 +55,7 @@ import androidx.media3.exoplayer.video.VideoRendererEventListener;
import androidx.media3.extractor.DefaultExtractorsFactory; import androidx.media3.extractor.DefaultExtractorsFactory;
import androidx.media3.extractor.mp4.Mp4Extractor; import androidx.media3.extractor.mp4.Mp4Extractor;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
import java.util.ArrayList;
/** An {@link AssetLoader} implementation that uses an {@link ExoPlayer} to load samples. */ /** An {@link AssetLoader} implementation that uses an {@link ExoPlayer} to load samples. */
@UnstableApi @UnstableApi
@ -270,21 +271,17 @@ public final class ExoPlayerAssetLoader implements AssetLoader {
AudioRendererEventListener audioRendererEventListener, AudioRendererEventListener audioRendererEventListener,
TextOutput textRendererOutput, TextOutput textRendererOutput,
MetadataOutput metadataRendererOutput) { MetadataOutput metadataRendererOutput) {
int rendererCount = removeAudio || removeVideo ? 1 : 2; ArrayList<Renderer> renderers = new ArrayList<>();
Renderer[] renderers = new Renderer[rendererCount];
int index = 0;
if (!removeAudio) { if (!removeAudio) {
renderers[index] = renderers.add(
new ExoAssetLoaderAudioRenderer(decoderFactory, mediaClock, assetLoaderListener); new ExoAssetLoaderAudioRenderer(decoderFactory, mediaClock, assetLoaderListener));
index++;
} }
if (!removeVideo) { if (!removeVideo) {
renderers[index] = renderers.add(
new ExoAssetLoaderVideoRenderer( new ExoAssetLoaderVideoRenderer(
flattenForSlowMotion, decoderFactory, hdrMode, mediaClock, assetLoaderListener); flattenForSlowMotion, decoderFactory, hdrMode, mediaClock, assetLoaderListener));
index++;
} }
return renderers; return renderers.toArray(new Renderer[renderers.size()]);
} }
} }