loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash when there's no input player view.

Browse Source 
This happens when the input is an image. The output will always be video so the
outputPlayer and outputVideoTextView will always present.

PiperOrigin-RevId: 524329436
This commit is contained in:
claincly 2023-04-14 18:42:06 +01:00 committed by Rohit Singh
parent b834e49f9f
commit eadb78e52a
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
demos/transformer/src/main/java/androidx/media3/demo/transformer/TransformerActivity.java
View File

@ -688,7 +688,6 @@ public final class TransformerActivity extends AppCompatActivity {
ExoPlayer outputPlayer = new ExoPlayer.Builder(/* context= */ this).build();
outputPlayerView.setPlayer(outputPlayer);
outputPlayerView.setControllerAutoShow(false);
outputPlayerView.setOnClickListener(this::onClickingPlayerView);
outputPlayer.setMediaItem(outputMediaItem);
outputPlayer.prepare();
this.outputPlayer = outputPlayer;
@ -716,6 +715,7 @@ public final class TransformerActivity extends AppCompatActivity {
inputPlayerView.setPlayer(inputPlayer);
inputPlayerView.setControllerAutoShow(false);
inputPlayerView.setOnClickListener(this::onClickingPlayerView);
outputPlayerView.setOnClickListener(this::onClickingPlayerView);
inputPlayer.setMediaItem(inputMediaItem);
inputPlayer.prepare();
this.inputPlayer = inputPlayer;
@ -730,13 +730,17 @@ public final class TransformerActivity extends AppCompatActivity {
private void onClickingPlayerView(View view) {
if (view == inputPlayerView) {
checkNotNull(inputPlayer).setVolume(1f);
checkNotNull(inputTextView).setText(R.string.input_video_playing_sound);
if (inputPlayer != null && inputTextView != null) {
inputPlayer.setVolume(1f);
inputTextView.setText(R.string.input_video_playing_sound);
}
checkNotNull(outputPlayer).setVolume(0f);
checkNotNull(outputVideoTextView).setText(R.string.output_video_no_sound);
} else {
checkNotNull(inputPlayer).setVolume(0f);
checkNotNull(inputTextView).setText(getString(R.string.input_video_no_sound));
if (inputPlayer != null && inputTextView != null) {
inputPlayer.setVolume(0f);
inputTextView.setText(getString(R.string.input_video_no_sound));
}
checkNotNull(outputPlayer).setVolume(1f);
checkNotNull(outputVideoTextView).setText(R.string.output_video_playing_sound);
}