From e9511a56eadd20bbee3ddf369b98d37a630a04fc Mon Sep 17 00:00:00 2001 From: tonihei Date: Fri, 24 Apr 2020 14:49:20 +0100 Subject: [PATCH] Deprecate onSeekProcessed. PiperOrigin-RevId: 308246116 --- RELEASENOTES.md | 2 ++ .../main/java/com/google/android/exoplayer2/Player.java | 6 +++--- .../android/exoplayer2/analytics/AnalyticsCollector.java | 1 + .../android/exoplayer2/analytics/AnalyticsListener.java | 7 ++++--- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index c300a06768..36e5332b4a 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -26,6 +26,8 @@ consistency. * Deprecate and rename `onLoadingChanged` to `onIsLoadingChanged` for consistency. + * Deprecate `onSeekProcessed` because all seek changes happen instantly + now and listening to `onPositionDiscontinuity` is sufficient. * Add `ExoPlayer.setPauseAtEndOfMediaItems` to let the player pause at the end of each media item ([#5660](https://github.com/google/ExoPlayer/issues/5660)). diff --git a/library/core/src/main/java/com/google/android/exoplayer2/Player.java b/library/core/src/main/java/com/google/android/exoplayer2/Player.java index f692629dff..83609e90d2 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/Player.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/Player.java @@ -582,10 +582,10 @@ public interface Player { default void onPlaybackSpeedChanged(float playbackSpeed) {} /** - * Called when all pending seek requests have been processed by the player. This is guaranteed - * to happen after any necessary changes to the player state were reported to {@link - * #onPlaybackStateChanged(int)}. + * @deprecated Seeks are processed without delay. Listen to {@link + * #onPositionDiscontinuity(int)} with reason {@link #DISCONTINUITY_REASON_SEEK} instead. */ + @Deprecated default void onSeekProcessed() {} } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java index 2af577fc4b..715a1c0f14 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java @@ -554,6 +554,7 @@ public class AnalyticsCollector } } + @SuppressWarnings("deprecation") @Override public final void onSeekProcessed() { EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime(); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java index 77bc211ee3..0b841ab543 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java @@ -190,10 +190,11 @@ public interface AnalyticsListener { default void onSeekStarted(EventTime eventTime) {} /** - * Called when a seek operation was processed. - * - * @param eventTime The event time. + * @deprecated Seeks are processed without delay. Listen to {@link + * #onPositionDiscontinuity(EventTime, int)} with reason {@link + * Player#DISCONTINUITY_REASON_SEEK} instead. */ + @Deprecated default void onSeekProcessed(EventTime eventTime) {} /**