loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify and improve text selection logic.

Browse Source 
This changes the logic in the following ways:
 - If no preferred language is matched, prefer better scores for the selected
   audio language.
 - If a preferred language is matched, always prefer the better match
   irrespective of default or forced flags.
 - If a preferred language score and the isForced flag is the same, prefer
   tracks with a better selected audio language match.

PiperOrigin-RevId: 259707430
This commit is contained in:
tonihei 2019-07-24 11:05:27 +01:00 committed by Toni
parent feb807897f
commit e84d88e90f
2 changed files with 17 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RELEASENOTES.md
View File

@ -34,6 +34,8 @@
([#6153](https://github.com/google/ExoPlayer/issues/6153)). ([#6153](https://github.com/google/ExoPlayer/issues/6153)).
* Add ability to specify a description when creating notification channels via * Add ability to specify a description when creating notification channels via
ExoPlayer library classes. ExoPlayer library classes.
* Improve text selection logic to always prefer the better language matches
over other selection parameters.
### 2.10.3 ### ### 2.10.3 ###

35
library/core/src/main/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelector.java
View File

@ -2536,9 +2536,9 @@ public class DefaultTrackSelector extends MappingTrackSelector {
private final boolean isWithinRendererCapabilities; private final boolean isWithinRendererCapabilities;
private final boolean isDefault; private final boolean isDefault;
private final boolean isForced; private final boolean hasPreferredIsForcedFlag;
private final int preferredLanguageScore; private final int preferredLanguageScore;
private final boolean isForcedAndSelectedAudioLanguage; private final int selectedAudioLanguageScore;
public TextTrackScore( public TextTrackScore(
Format format, Format format,
@ -2550,17 +2550,21 @@ public class DefaultTrackSelector extends MappingTrackSelector {
int maskedSelectionFlags = int maskedSelectionFlags =
format.selectionFlags & ~parameters.disabledTextTrackSelectionFlags; format.selectionFlags & ~parameters.disabledTextTrackSelectionFlags;
isDefault = (maskedSelectionFlags & C.SELECTION_FLAG_DEFAULT) != 0; isDefault = (maskedSelectionFlags & C.SELECTION_FLAG_DEFAULT) != 0;
isForced = (maskedSelectionFlags & C.SELECTION_FLAG_FORCED) != 0; boolean isForced = (maskedSelectionFlags & C.SELECTION_FLAG_FORCED) != 0;
preferredLanguageScore = preferredLanguageScore =
getFormatLanguageScore( getFormatLanguageScore(
format, parameters.preferredTextLanguage, parameters.selectUndeterminedTextLanguage); format, parameters.preferredTextLanguage, parameters.selectUndeterminedTextLanguage);
// Prefer non-forced to forced if a preferred text language has been matched. Where both are
// provided the non-forced track will usually contain the forced subtitles as a subset.
// Otherwise, prefer a forced track.
hasPreferredIsForcedFlag =
(preferredLanguageScore > 0 && !isForced) || (preferredLanguageScore == 0 && isForced);
boolean selectedAudioLanguageUndetermined = boolean selectedAudioLanguageUndetermined =
normalizeUndeterminedLanguageToNull(selectedAudioLanguage) == null; normalizeUndeterminedLanguageToNull(selectedAudioLanguage) == null;
int selectedAudioLanguageScore = selectedAudioLanguageScore =
getFormatLanguageScore(format, selectedAudioLanguage, selectedAudioLanguageUndetermined); getFormatLanguageScore(format, selectedAudioLanguage, selectedAudioLanguageUndetermined);
isForcedAndSelectedAudioLanguage = isForced && selectedAudioLanguageScore > 0;
isWithinConstraints = isWithinConstraints =
preferredLanguageScore > 0 || isDefault || isForcedAndSelectedAudioLanguage; preferredLanguageScore > 0 || isDefault || (isForced && selectedAudioLanguageScore > 0);
} }
/** /**
@ -2575,25 +2579,16 @@ public class DefaultTrackSelector extends MappingTrackSelector {
if (this.isWithinRendererCapabilities != other.isWithinRendererCapabilities) { if (this.isWithinRendererCapabilities != other.isWithinRendererCapabilities) {
return this.isWithinRendererCapabilities ? 1 : -1; return this.isWithinRendererCapabilities ? 1 : -1;
} }
if ((this.preferredLanguageScore > 0) != (other.preferredLanguageScore > 0)) { if (this.preferredLanguageScore != other.preferredLanguageScore) {
return this.preferredLanguageScore > 0 ? 1 : -1; return compareInts(this.preferredLanguageScore, other.preferredLanguageScore);
} }
if (this.isDefault != other.isDefault) { if (this.isDefault != other.isDefault) {
return this.isDefault ? 1 : -1; return this.isDefault ? 1 : -1;
} }
if (this.preferredLanguageScore > 0) { if (this.hasPreferredIsForcedFlag != other.hasPreferredIsForcedFlag) {
if (this.isForced != other.isForced) { return this.hasPreferredIsForcedFlag ? 1 : -1;
// Prefer non-forced to forced if a preferred text language has been specified. Where
// both are provided the non-forced track will usually contain the forced subtitles as
// a subset.
return !this.isForced ? 1 : -1;
}
return compareInts(this.preferredLanguageScore, other.preferredLanguageScore);
} }
if (this.isForcedAndSelectedAudioLanguage != other.isForcedAndSelectedAudioLanguage) { return compareInts(this.selectedAudioLanguageScore, other.selectedAudioLanguageScore);
return this.isForcedAndSelectedAudioLanguage ? 1 : -1;
}
return 0;
} }
} }
} }