loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update notification play/pause button with matching player state

Browse Source 
Issue: androidx/media#192
PiperOrigin-RevId: 508649684
This commit is contained in:
tianyifeng 2023-02-10 14:57:53 +00:00 committed by christosts
parent 574424f626
commit e1d12fc395
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RELEASENOTES.md
View File

@ -81,6 +81,8 @@
([#233](https://github.com/androidx/media/issues/233)). ([#233](https://github.com/androidx/media/issues/233)).
* Make `QueueTimeline` more robust in case of a shady legacy session state * Make `QueueTimeline` more robust in case of a shady legacy session state
([#241](https://github.com/androidx/media/issues/241)). ([#241](https://github.com/androidx/media/issues/241)).
* Fix a bug where notification play/pause button doesn't update with
player state ([#192](https://github.com/androidx/media/issues/192)).
* Metadata: * Metadata:
* Parse multiple null-separated values from ID3 frames, as permitted by * Parse multiple null-separated values from ID3 frames, as permitted by
ID3 v2.4. ID3 v2.4.

4
libraries/session/src/main/java/androidx/media3/session/MediaNotificationManager.java
View File

@ -219,9 +219,11 @@ import java.util.concurrent.TimeoutException;
if (startInForegroundRequired) { if (startInForegroundRequired) {
startForeground(mediaNotification); startForeground(mediaNotification);
} else { } else {
maybeStopForegroundService(/* removeNotifications= */ false); // Notification manager has to be updated first to avoid missing updates
// (https://github.com/androidx/media/issues/192).
notificationManagerCompat.notify( notificationManagerCompat.notify(
mediaNotification.notificationId, mediaNotification.notification); mediaNotification.notificationId, mediaNotification.notification);
maybeStopForegroundService(/* removeNotifications= */ false);
} }
} }