From e10f96d6a61bcc9e1f99d9e657f28db89e4d7af7 Mon Sep 17 00:00:00 2001 From: tonihei Date: Tue, 19 Dec 2023 04:36:09 -0800 Subject: [PATCH] Make some DefaultRenderersFactory methods final These methods are just setters and not meant to be overridden. PiperOrigin-RevId: 592193857 --- .../exoplayer/DefaultRenderersFactory.java | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/DefaultRenderersFactory.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/DefaultRenderersFactory.java index 49fb1beadf..7dbf06c86d 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/DefaultRenderersFactory.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/DefaultRenderersFactory.java @@ -129,7 +129,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setExtensionRendererMode( + public final DefaultRenderersFactory setExtensionRendererMode( @ExtensionRendererMode int extensionRendererMode) { this.extensionRendererMode = extensionRendererMode; return this; @@ -145,7 +145,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory forceEnableMediaCodecAsynchronousQueueing() { + public final DefaultRenderersFactory forceEnableMediaCodecAsynchronousQueueing() { codecAdapterFactory.forceEnableAsynchronous(); return this; } @@ -158,7 +158,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory forceDisableMediaCodecAsynchronousQueueing() { + public final DefaultRenderersFactory forceDisableMediaCodecAsynchronousQueueing() { codecAdapterFactory.forceDisableAsynchronous(); return this; } @@ -171,7 +171,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * in a future release. */ @CanIgnoreReturnValue - public DefaultRenderersFactory experimentalSetMediaCodecAsyncCryptoFlagEnabled( + public final DefaultRenderersFactory experimentalSetMediaCodecAsyncCryptoFlagEnabled( boolean enableAsyncCryptoFlag) { codecAdapterFactory.experimentalSetAsyncCryptoFlagEnabled(enableAsyncCryptoFlag); return this; @@ -186,7 +186,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setEnableDecoderFallback(boolean enableDecoderFallback) { + public final DefaultRenderersFactory setEnableDecoderFallback(boolean enableDecoderFallback) { this.enableDecoderFallback = enableDecoderFallback; return this; } @@ -200,7 +200,8 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setMediaCodecSelector(MediaCodecSelector mediaCodecSelector) { + public final DefaultRenderersFactory setMediaCodecSelector( + MediaCodecSelector mediaCodecSelector) { this.mediaCodecSelector = mediaCodecSelector; return this; } @@ -217,7 +218,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setEnableAudioFloatOutput(boolean enableFloatOutput) { + public final DefaultRenderersFactory setEnableAudioFloatOutput(boolean enableFloatOutput) { this.enableFloatOutput = enableFloatOutput; return this; } @@ -241,7 +242,7 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setEnableAudioTrackPlaybackParams( + public final DefaultRenderersFactory setEnableAudioTrackPlaybackParams( boolean enableAudioTrackPlaybackParams) { this.enableAudioTrackPlaybackParams = enableAudioTrackPlaybackParams; return this; @@ -258,7 +259,8 @@ public class DefaultRenderersFactory implements RenderersFactory { * @return This factory, for convenience. */ @CanIgnoreReturnValue - public DefaultRenderersFactory setAllowedVideoJoiningTimeMs(long allowedVideoJoiningTimeMs) { + public final DefaultRenderersFactory setAllowedVideoJoiningTimeMs( + long allowedVideoJoiningTimeMs) { this.allowedVideoJoiningTimeMs = allowedVideoJoiningTimeMs; return this; }