loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove non actionable TODOs from Mp4Muxer code

Browse Source 
PiperOrigin-RevId: 615372415
This commit is contained in:
sheenachhabra 2024-03-13 05:01:59 -07:00 committed by Copybara-Service
parent 12aa637fa1
commit dfe9fba17d
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/muxer/src/main/java/androidx/media3/muxer/FragmentedMp4Writer.java
View File

@ -179,8 +179,6 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
private void createHeader() throws IOException { private void createHeader() throws IOException {
output.position(0L); output.position(0L);
output.write(Boxes.ftyp()); output.write(Boxes.ftyp());
// TODO: b/262704382 - Add some free space in the moov box to fit any newly added metadata and
// write moov box again in the close() method.
// The minInputPtsUs is actually ignored as there are no pending samples to write. // The minInputPtsUs is actually ignored as there are no pending samples to write.
output.write( output.write(
moovGenerator.moovMetadataHeader( moovGenerator.moovMetadataHeader(

1
libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java
View File

@ -196,7 +196,6 @@ public final class Mp4Muxer {
public static final ImmutableList<String> SUPPORTED_AUDIO_SAMPLE_MIME_TYPES = public static final ImmutableList<String> SUPPORTED_AUDIO_SAMPLE_MIME_TYPES =
ImmutableList.of(MimeTypes.AUDIO_AAC); ImmutableList.of(MimeTypes.AUDIO_AAC);
// TODO: b/262704382 - Optimize the default duration.
/** /**
* The default fragment duration for the {@linkplain Builder#setFragmentedMp4Enabled(boolean) * The default fragment duration for the {@linkplain Builder#setFragmentedMp4Enabled(boolean)
* fragmented MP4}. * fragmented MP4}.