From dfe9fba17dcfb7d3c1df2c0505bc09a68237f01a Mon Sep 17 00:00:00 2001 From: sheenachhabra Date: Wed, 13 Mar 2024 05:01:59 -0700 Subject: [PATCH] Remove non actionable TODOs from Mp4Muxer code PiperOrigin-RevId: 615372415 --- .../main/java/androidx/media3/muxer/FragmentedMp4Writer.java | 2 -- .../muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java | 1 - 2 files changed, 3 deletions(-) diff --git a/libraries/muxer/src/main/java/androidx/media3/muxer/FragmentedMp4Writer.java b/libraries/muxer/src/main/java/androidx/media3/muxer/FragmentedMp4Writer.java index 9e33d576d6..dd2756690b 100644 --- a/libraries/muxer/src/main/java/androidx/media3/muxer/FragmentedMp4Writer.java +++ b/libraries/muxer/src/main/java/androidx/media3/muxer/FragmentedMp4Writer.java @@ -179,8 +179,6 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull; private void createHeader() throws IOException { output.position(0L); output.write(Boxes.ftyp()); - // TODO: b/262704382 - Add some free space in the moov box to fit any newly added metadata and - // write moov box again in the close() method. // The minInputPtsUs is actually ignored as there are no pending samples to write. output.write( moovGenerator.moovMetadataHeader( diff --git a/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java b/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java index 12a5a213fd..c4f4defa12 100644 --- a/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java +++ b/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Muxer.java @@ -196,7 +196,6 @@ public final class Mp4Muxer { public static final ImmutableList SUPPORTED_AUDIO_SAMPLE_MIME_TYPES = ImmutableList.of(MimeTypes.AUDIO_AAC); - // TODO: b/262704382 - Optimize the default duration. /** * The default fragment duration for the {@linkplain Builder#setFragmentedMp4Enabled(boolean) * fragmented MP4}.