From d74eb7500f2af4dec0ec65f8bee091ce91d0d5bb Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Wed, 23 Nov 2022 18:40:09 +0000 Subject: [PATCH] Transformer: Document when OMX video codecs will no longer exist. We cannot check this in code, due to DEVICE_INITIAL_SDK_INT being a @SystemApi, and reflection being a bit risky/unstable. PiperOrigin-RevId: 490537916 --- .../main/java/androidx/media3/transformer/DefaultCodec.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultCodec.java b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultCodec.java index baa1884600..9cdcd6d5d6 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultCodec.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultCodec.java @@ -160,7 +160,8 @@ public final class DefaultCodec implements Codec { // stuck if too many frames are rendered without being processed, so limit the number of // pending frames to avoid getting stuck. This value is experimentally determined. See also // b/213455700, b/230097284, b/229978305, and b/245491744. - // TODO(b/230097284): Add a maximum API check after we know which APIs will never use OMX. + // + // OMX video codecs should no longer exist from android.os.Build.DEVICE_INITIAL_SDK_INT 31+. return 5; } // Otherwise don't limit the number of frames that can be pending at a time, to maximize