loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make DefaultHttpDataSourceContractTest an instrumentation test

Browse Source 
Robolectric uses the JRE HttpURLConnection [1], while real Android
devices and emulators use OkHttp to implement HttpURLConnection. This
can lead to important differences in behaviour, so it's better to use
instrumentation tests when specific HTTP behaviour is important.

[1] https://github.com/robolectric/robolectric/issues/6769#issuecomment-943556156

PiperOrigin-RevId: 408840295
This commit is contained in:
ibaker 2021-11-10 12:00:57 +00:00 committed by Ian Baker
parent ad305b44a0
commit d1e12dcddf
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/datasource/src/androidTest/AndroidManifest.xml
View File

@ -18,10 +18,12 @@
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
package="androidx.media3.datasource.test"> package="androidx.media3.datasource.test">
<uses-permission android:name="android.permission.INTERNET"/>
<uses-sdk/> <uses-sdk/>
<application <application
android:allowBackup="false" android:allowBackup="false"
android:usesCleartextTraffic="true"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"> tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
<provider <provider
android:authorities="androidx.media3.test.utils.AssetContentProvider" android:authorities="androidx.media3.test.utils.AssetContentProvider"

0
libraries/datasource/src/test/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java → libraries/datasource/src/androidTest/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java
View File