From d1e12dcddf0ea6d00a8b0d2df6786e7f06ad7e2f Mon Sep 17 00:00:00 2001
From: ibaker <ibaker@google.com>
Date: Wed, 10 Nov 2021 12:00:57 +0000
Subject: [PATCH] Make DefaultHttpDataSourceContractTest an instrumentation
 test

Robolectric uses the JRE HttpURLConnection [1], while real Android
devices and emulators use OkHttp to implement HttpURLConnection. This
can lead to important differences in behaviour, so it's better to use
instrumentation tests when specific HTTP behaviour is important.

[1] https://github.com/robolectric/robolectric/issues/6769#issuecomment-943556156

PiperOrigin-RevId: 408840295
---
 libraries/datasource/src/androidTest/AndroidManifest.xml        | 2 ++
 .../media3/datasource/DefaultHttpDataSourceContractTest.java    | 0
 2 files changed, 2 insertions(+)
 rename libraries/datasource/src/{test => androidTest}/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java (100%)

diff --git a/libraries/datasource/src/androidTest/AndroidManifest.xml b/libraries/datasource/src/androidTest/AndroidManifest.xml
index 91bb550add..6dadf00eb5 100644
--- a/libraries/datasource/src/androidTest/AndroidManifest.xml
+++ b/libraries/datasource/src/androidTest/AndroidManifest.xml
@@ -18,10 +18,12 @@
     xmlns:tools="http://schemas.android.com/tools"
     package="androidx.media3.datasource.test">
 
+  <uses-permission android:name="android.permission.INTERNET"/>
   <uses-sdk/>
 
   <application
       android:allowBackup="false"
+      android:usesCleartextTraffic="true"
       tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
     <provider
       android:authorities="androidx.media3.test.utils.AssetContentProvider"
diff --git a/libraries/datasource/src/test/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java b/libraries/datasource/src/androidTest/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java
similarity index 100%
rename from libraries/datasource/src/test/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java
rename to libraries/datasource/src/androidTest/java/androidx/media3/datasource/DefaultHttpDataSourceContractTest.java