loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix command check in MediaControllerImplBase

Browse Source 
The command check for setDeviceMuted was wrong.

PiperOrigin-RevId: 502355332
This commit is contained in:
tonihei 2023-01-16 12:50:20 +00:00 committed by Rohit Singh
parent a2a44cdc02
commit cfcce9aec9
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/session/src/main/java/androidx/media3/session/MediaControllerImplBase.java
View File

@ -1468,7 +1468,7 @@ import org.checkerframework.checker.nullness.qual.NonNull;
@Override @Override
public void setDeviceMuted(boolean muted) { public void setDeviceMuted(boolean muted) {
if (!isPlayerCommandAvailable(Player.COMMAND_SET_DEVICE_VOLUME)) { if (!isPlayerCommandAvailable(Player.COMMAND_ADJUST_DEVICE_VOLUME)) {
return; return;
} }

2
libraries/session/src/main/java/androidx/media3/session/MediaSessionStub.java
View File

@ -1324,7 +1324,7 @@ import java.util.concurrent.ExecutionException;
queueSessionTaskWithPlayerCommand( queueSessionTaskWithPlayerCommand(
caller, caller,
sequenceNumber, sequenceNumber,
COMMAND_SET_DEVICE_VOLUME, COMMAND_ADJUST_DEVICE_VOLUME,
sendSessionResultSuccess(player -> player.setDeviceMuted(muted))); sendSessionResultSuccess(player -> player.setDeviceMuted(muted)));
} }

3
libraries/test_session_current/src/androidTest/java/androidx/media3/session/MediaSessionPermissionTest.java
View File

@ -185,7 +185,8 @@ public class MediaSessionPermissionTest {
@Test @Test
public void setDeviceMuted() throws Exception { public void setDeviceMuted() throws Exception {
testOnCommandRequest(COMMAND_SET_DEVICE_VOLUME, controller -> controller.setDeviceMuted(true)); testOnCommandRequest(
COMMAND_ADJUST_DEVICE_VOLUME, controller -> controller.setDeviceMuted(true));
} }
@Test @Test