From ce0e3a4fa3e829c987e541f30694a73d8abbc25b Mon Sep 17 00:00:00 2001 From: leonwind Date: Tue, 6 Sep 2022 12:37:47 +0000 Subject: [PATCH] Make MatrixTransformationsProcessor constructor to take in Lists. * Replace ImmutableLists to List interface for constructors PiperOrigin-RevId: 472433434 --- .../effect/MatrixTransformationProcessor.java | 41 +++++++++++++------ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/google3/third_party/java_src/android_libs/media/libraries/effect/src/main/java/androidx/media3/effect/MatrixTransformationProcessor.java b/google3/third_party/java_src/android_libs/media/libraries/effect/src/main/java/androidx/media3/effect/MatrixTransformationProcessor.java index 6cef8653d9..62c0490a84 100644 --- a/google3/third_party/java_src/android_libs/media/libraries/effect/src/main/java/androidx/media3/effect/MatrixTransformationProcessor.java +++ b/google3/third_party/java_src/android_libs/media/libraries/effect/src/main/java/androidx/media3/effect/MatrixTransformationProcessor.java @@ -31,6 +31,7 @@ import com.google.android.exoplayer2.video.ColorInfo; import com.google.common.collect.ImmutableList; import java.io.IOException; import java.util.Arrays; +import java.util.List; /** * Applies a sequence of {@link MatrixTransformation MatrixTransformations} in the vertex shader and @@ -134,8 +135,8 @@ import java.util.Arrays; */ public static MatrixTransformationProcessor create( Context context, - ImmutableList matrixTransformations, - ImmutableList rgbMatrices, + List matrixTransformations, + List rgbMatrices, boolean useHdr) throws FrameProcessingException { GlProgram glProgram = @@ -143,7 +144,11 @@ import java.util.Arrays; context, VERTEX_SHADER_TRANSFORMATION_PATH, FRAGMENT_SHADER_TRANSFORMATION_PATH); // No transfer functions needed, because input and output are both optical colors. - return new MatrixTransformationProcessor(glProgram, matrixTransformations, rgbMatrices, useHdr); + return new MatrixTransformationProcessor( + glProgram, + ImmutableList.copyOf(matrixTransformations), + ImmutableList.copyOf(rgbMatrices), + useHdr); } /** @@ -171,8 +176,8 @@ import java.util.Arrays; */ public static MatrixTransformationProcessor createWithExternalSamplerApplyingEotf( Context context, - ImmutableList matrixTransformations, - ImmutableList rgbMatrices, + List matrixTransformations, + List rgbMatrices, ColorInfo electricalColorInfo) throws FrameProcessingException { boolean useHdr = ColorInfo.isTransferHdr(electricalColorInfo); @@ -203,7 +208,11 @@ import java.util.Arrays; glProgram.setIntUniform("uEotfColorTransfer", colorTransfer); } - return new MatrixTransformationProcessor(glProgram, matrixTransformations, rgbMatrices, useHdr); + return new MatrixTransformationProcessor( + glProgram, + ImmutableList.copyOf(matrixTransformations), + ImmutableList.copyOf(rgbMatrices), + useHdr); } /** @@ -227,8 +236,8 @@ import java.util.Arrays; */ public static MatrixTransformationProcessor createApplyingOetf( Context context, - ImmutableList matrixTransformations, - ImmutableList rgbMatrices, + List matrixTransformations, + List rgbMatrices, ColorInfo electricalColorInfo) throws FrameProcessingException { boolean useHdr = ColorInfo.isTransferHdr(electricalColorInfo); @@ -246,7 +255,11 @@ import java.util.Arrays; glProgram.setIntUniform("uOetfColorTransfer", colorTransfer); } - return new MatrixTransformationProcessor(glProgram, matrixTransformations, rgbMatrices, useHdr); + return new MatrixTransformationProcessor( + glProgram, + ImmutableList.copyOf(matrixTransformations), + ImmutableList.copyOf(rgbMatrices), + useHdr); } /** @@ -270,8 +283,8 @@ import java.util.Arrays; */ public static MatrixTransformationProcessor createWithExternalSamplerApplyingEotfThenOetf( Context context, - ImmutableList matrixTransformations, - ImmutableList rgbMatrices, + List matrixTransformations, + List rgbMatrices, ColorInfo electricalColorInfo) throws FrameProcessingException { boolean useHdr = ColorInfo.isTransferHdr(electricalColorInfo); @@ -300,7 +313,11 @@ import java.util.Arrays; glProgram.setIntUniform("uEotfColorTransfer", Format.NO_VALUE); } - return new MatrixTransformationProcessor(glProgram, matrixTransformations, rgbMatrices, useHdr); + return new MatrixTransformationProcessor( + glProgram, + ImmutableList.copyOf(matrixTransformations), + ImmutableList.copyOf(rgbMatrices), + useHdr); } /**