loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow MP3 files to play with size greater than 2GB.

Browse Source 
Issue:#7337
PiperOrigin-RevId: 312042768
This commit is contained in:
samrobinson 2020-05-18 10:32:23 +01:00 committed by Andrew Lewis
parent 8188c29279
commit cda9417aa6
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
RELEASENOTES.md
View File

@ -158,11 +158,14 @@
marked with the `C.ROLE_FLAG_TRICK_PLAY` flag.
* Fix assertion failure in `SampleQueue` when playing DASH streams with
EMSG tracks ([#7273](https://github.com/google/ExoPlayer/issues/7273)).
* MP3: Add `IndexSeeker` for accurate seeks in VBR streams
([#6787](https://github.com/google/ExoPlayer/issues/6787)). This seeker is
enabled by passing `FLAG_ENABLE_INDEX_SEEKING` to the `Mp3Extractor`. It may
require to scan a significant portion of the file for seeking, which may be
costly on large files.
* MP3:
* Add `IndexSeeker` for accurate seeks in VBR streams
([#6787](https://github.com/google/ExoPlayer/issues/6787)). This seeker
is enabled by passing `FLAG_ENABLE_INDEX_SEEKING` to the `Mp3Extractor`.
It may require to scan a significant portion of the file for seeking,
which may be costly on large files.
* Allow MP3 files with XING headers that are larger than 2GB to be played
([#7337](https://github.com/google/ExoPlayer/issues/7337)).
* MP4: Store the Android capture frame rate only in `Format.metadata`.
`Format.frameRate` now stores the calculated frame rate.
* MPEG-TS: Fix issue where SEI NAL units were incorrectly dropped from H.265

2
library/extractor/src/main/java/com/google/android/exoplayer2/extractor/mp3/XingSeeker.java
View File

@ -64,7 +64,7 @@ import com.google.android.exoplayer2.util.Util;
return new XingSeeker(position, mpegAudioHeader.frameSize, durationUs);
}
long dataSize = frame.readUnsignedIntToInt();
long dataSize = frame.readUnsignedInt();
long[] tableOfContents = new long[100];
for (int i = 0; i < 100; i++) {
tableOfContents[i] = frame.readUnsignedByte();