loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Re-assign TODOs

Browse Source 
PiperOrigin-RevId: 493281221
This commit is contained in:
claincly 2022-12-06 13:54:56 +00:00 committed by Ian Baker
parent 636a4a8538
commit cc43ddb528
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/transformer/src/main/java/androidx/media3/transformer/AudioTranscodingSamplePipeline.java
View File

@ -334,8 +334,8 @@ import org.checkerframework.dataflow.qual.Pure;
@Pure @Pure
private static TransformationRequest createFallbackTransformationRequest( private static TransformationRequest createFallbackTransformationRequest(
TransformationRequest transformationRequest, Format requestedFormat, Format actualFormat) { TransformationRequest transformationRequest, Format requestedFormat, Format actualFormat) {
// TODO(b/210591626): Also update bitrate and other params once encoder configuration and // TODO(b/259570024): Consider including bitrate and other audio characteristics in the revised
// fallback are implemented. // fallback design.
if (Util.areEqual(requestedFormat.sampleMimeType, actualFormat.sampleMimeType)) { if (Util.areEqual(requestedFormat.sampleMimeType, actualFormat.sampleMimeType)) {
return transformationRequest; return transformationRequest;
} }

1
libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java
View File

@ -175,7 +175,6 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory {
@Override @Override
public DefaultCodec createForAudioEncoding(Format format) throws TransformationException { public DefaultCodec createForAudioEncoding(Format format) throws TransformationException {
// TODO(b/210591626) Add encoder selection for audio.
checkNotNull(format.sampleMimeType); checkNotNull(format.sampleMimeType);
MediaFormat mediaFormat = MediaFormat mediaFormat =
MediaFormat.createAudioFormat( MediaFormat.createAudioFormat(

3
libraries/transformer/src/main/java/androidx/media3/transformer/VideoTranscodingSamplePipeline.java
View File

@ -325,8 +325,7 @@ import org.checkerframework.dataflow.qual.Pure;
Format requestedFormat, Format requestedFormat,
Format supportedFormat, Format supportedFormat,
@TransformationRequest.HdrMode int supportedHdrMode) { @TransformationRequest.HdrMode int supportedHdrMode) {
// TODO(b/210591626): Also update bitrate etc. once encoder configuration and fallback are // TODO(b/259570024): Consider including bitrate in the revised fallback design.
// implemented.
if (transformationRequest.hdrMode == supportedHdrMode if (transformationRequest.hdrMode == supportedHdrMode
&& Util.areEqual(requestedFormat.sampleMimeType, supportedFormat.sampleMimeType) && Util.areEqual(requestedFormat.sampleMimeType, supportedFormat.sampleMimeType)
&& (hasOutputFormatRotation && (hasOutputFormatRotation