From ca61ac6ca35427a697a6645c90cc8e12889c78f7 Mon Sep 17 00:00:00 2001 From: ibaker Date: Tue, 23 Jan 2024 03:47:30 -0800 Subject: [PATCH] Release `MediaSession` and `ExoPlayer` in `MediaControllerStubTest` Due to poor isolation between the session tests, in particular the static state in `MediaSession.SESSION_ID_TO_SESSION_MAP`, an unreleased session at the end of one test can cause subsequent tests to fail with obscure errors like `Session ID must be unique`. #minor-release PiperOrigin-RevId: 600737697 --- .../java/androidx/media3/session/MediaControllerStubTest.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libraries/session/src/test/java/androidx/media3/session/MediaControllerStubTest.java b/libraries/session/src/test/java/androidx/media3/session/MediaControllerStubTest.java index 31b6ace097..33d0969607 100644 --- a/libraries/session/src/test/java/androidx/media3/session/MediaControllerStubTest.java +++ b/libraries/session/src/test/java/androidx/media3/session/MediaControllerStubTest.java @@ -139,5 +139,8 @@ public class MediaControllerStubTest { /* query= */ "", /* itemCount= */ 1, /* libraryParams= */ getThrowingBundle()); + + session.release(); + player.release(); } }