loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use int for an unsigned byte value in Cea608Decoder

Browse Source 
This is a no-op, but it's more 'correct' because it avoids any potential
sign mix-ups that come from storing an unsigned byte (with a
potentially set MSB) in a signed java byte variable.

PiperOrigin-RevId: 483409798
This commit is contained in:
ibaker 2022-10-24 16:51:08 +00:00 committed by microkatz
parent 8723e74b1f
commit c9a0aa9db0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea608Decoder.java
View File

@ -460,8 +460,8 @@ public final class Cea608Decoder extends CeaDecoder {
ccData.reset(subtitleData.array(), subtitleData.limit()); ccData.reset(subtitleData.array(), subtitleData.limit());
boolean captionDataProcessed = false; boolean captionDataProcessed = false;
while (ccData.bytesLeft() >= packetLength) { while (ccData.bytesLeft() >= packetLength) {
byte ccHeader = int ccHeader = packetLength == 2 ? CC_IMPLICIT_DATA_HEADER : ccData.readUnsignedByte();
packetLength == 2 ? CC_IMPLICIT_DATA_HEADER : (byte) ccData.readUnsignedByte();
int ccByte1 = ccData.readUnsignedByte(); int ccByte1 = ccData.readUnsignedByte();
int ccByte2 = ccData.readUnsignedByte(); int ccByte2 = ccData.readUnsignedByte();