From c9a0aa9db0a44555727660957901cc601d32b16c Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 24 Oct 2022 16:51:08 +0000 Subject: [PATCH] Use int for an unsigned byte value in Cea608Decoder This is a no-op, but it's more 'correct' because it avoids any potential sign mix-ups that come from storing an unsigned byte (with a potentially set MSB) in a signed java byte variable. PiperOrigin-RevId: 483409798 --- .../androidx/media3/extractor/text/cea/Cea608Decoder.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea608Decoder.java b/libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea608Decoder.java index a27f0bdeae..b73e303825 100644 --- a/libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea608Decoder.java +++ b/libraries/extractor/src/main/java/androidx/media3/extractor/text/cea/Cea608Decoder.java @@ -460,8 +460,8 @@ public final class Cea608Decoder extends CeaDecoder { ccData.reset(subtitleData.array(), subtitleData.limit()); boolean captionDataProcessed = false; while (ccData.bytesLeft() >= packetLength) { - byte ccHeader = - packetLength == 2 ? CC_IMPLICIT_DATA_HEADER : (byte) ccData.readUnsignedByte(); + int ccHeader = packetLength == 2 ? CC_IMPLICIT_DATA_HEADER : ccData.readUnsignedByte(); + int ccByte1 = ccData.readUnsignedByte(); int ccByte2 = ccData.readUnsignedByte();