loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make flag for debug traces in logcat private and final.

Browse Source 
PiperOrigin-RevId: 635465538
This commit is contained in:
samrobinson 2024-05-20 08:36:14 -07:00 committed by Copybara-Service
parent 07ddc0fca5
commit c9854cd695
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
libraries/effect/src/main/java/androidx/media3/effect/DebugTraceUtil.java
View File

@ -56,17 +56,6 @@ public final class DebugTraceUtil {
@SuppressWarnings("NonFinalStaticField") // Only for debugging/testing. @SuppressWarnings("NonFinalStaticField") // Only for debugging/testing.
public static boolean enableTracing = false; public static boolean enableTracing = false;
/**
* Whether to {@linkplain Log#d(String, String) log} tracing events to the logcat as they occur.
* Should be set to {@code true} for testing and debugging purposes only.
*
* <p>Note that enabling this can add a large amount of logcat lines.
*
* <p>Requires {@link #enableTracing} to be true.
*/
@SuppressWarnings("NonFinalStaticField") // Only for debugging/testing.
public static boolean enableTracesInLogcat = false;
/** Events logged by {@link #logEvent}. */ /** Events logged by {@link #logEvent}. */
@Documented @Documented
@Retention(RetentionPolicy.SOURCE) @Retention(RetentionPolicy.SOURCE)
@ -232,6 +221,16 @@ public final class DebugTraceUtil {
EVENT_OUTPUT_ENDED)) EVENT_OUTPUT_ENDED))
.buildOrThrow(); .buildOrThrow();
/**
* Whether to {@linkplain Log#d(String, String) log} tracing events to the logcat as they occur.
* Should be set to {@code true} for testing and debugging purposes only.
*
* <p>Note that enabling this can add a large amount of logcat lines.
*
* <p>Requires {@link #enableTracing} to be true.
*/
private static final boolean ENABLE_TRACES_IN_LOGCAT = false;
private static final int MAX_FIRST_LAST_LOGS = 10; private static final int MAX_FIRST_LAST_LOGS = 10;
@GuardedBy("DebugTraceUtil.class") @GuardedBy("DebugTraceUtil.class")
@ -280,7 +279,7 @@ public final class DebugTraceUtil {
String extra = Util.formatInvariant(extraFormat, extraArgs); String extra = Util.formatInvariant(extraFormat, extraArgs);
EventLog eventLog = new EventLog(presentationTimeUs, eventTimeMs, extra); EventLog eventLog = new EventLog(presentationTimeUs, eventTimeMs, extra);
logger.addLog(eventLog); logger.addLog(eventLog);
if (enableTracesInLogcat) { if (ENABLE_TRACES_IN_LOGCAT) {
Log.d("DebugTrace-" + component, event + ": " + eventLog); Log.d("DebugTrace-" + component, event + ": " + eventLog);
} }
} }