From c96bcbb24bc691053bf274835d3de1f8ab57da13 Mon Sep 17 00:00:00 2001 From: hschlueter Date: Tue, 1 Mar 2022 12:53:39 +0000 Subject: [PATCH] Avoid duplicate logging of GL exceptions. Only log GL exceptions in GlUtil if they aren't thrown. Otherwise, it's up to the caller whether or not to log them to avoid logging them twice. PiperOrigin-RevId: 431657397 --- .../src/main/java/androidx/media3/common/util/GlUtil.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java b/libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java index 16b040dc47..aa1e0332f6 100644 --- a/libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java +++ b/libraries/common/src/main/java/androidx/media3/common/util/GlUtil.java @@ -377,9 +377,10 @@ public final class GlUtil { } /* package */ static void throwGlException(String errorMsg) { - Log.e(TAG, errorMsg); if (glAssertionsEnabled) { throw new GlException(errorMsg); + } else { + Log.e(TAG, errorMsg); } }