loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce the number of allocations in SubtitlePainter.setupTextLayout

Browse Source 
PiperOrigin-RevId: 292877661
This commit is contained in:
ibaker 2020-02-03 10:22:18 +00:00 committed by Oliver Woodman
parent 3a702cf53a
commit c7ea8bbf1a
1 changed files with 19 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
library/ui/src/main/java/com/google/android/exoplayer2/ui/SubtitlePainter.java
View File

@ -242,7 +242,10 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
@RequiresNonNull("cueText") @RequiresNonNull("cueText")
private void setupTextLayout() { private void setupTextLayout() {
CharSequence cueText = this.cueText; SpannableStringBuilder cueText =
this.cueText instanceof SpannableStringBuilder
? (SpannableStringBuilder) this.cueText
: new SpannableStringBuilder(this.cueText);
int parentWidth = parentRight - parentLeft; int parentWidth = parentRight - parentLeft;
int parentHeight = parentBottom - parentTop; int parentHeight = parentBottom - parentTop;
@ -260,40 +263,36 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
// Remove embedded styling or font size if requested. // Remove embedded styling or font size if requested.
if (!applyEmbeddedStyles) { if (!applyEmbeddedStyles) {
cueText = cueText.toString(); // Equivalent to erasing all spans. // Remove all spans, regardless of type.
for (Object span : cueText.getSpans(0, cueText.length(), Object.class)) {
cueText.removeSpan(span);
}
} else if (!applyEmbeddedFontSizes) { } else if (!applyEmbeddedFontSizes) {
SpannableStringBuilder newCueText = new SpannableStringBuilder(cueText); AbsoluteSizeSpan[] absSpans = cueText.getSpans(0, cueText.length(), AbsoluteSizeSpan.class);
int cueLength = newCueText.length();
AbsoluteSizeSpan[] absSpans = newCueText.getSpans(0, cueLength, AbsoluteSizeSpan.class);
RelativeSizeSpan[] relSpans = newCueText.getSpans(0, cueLength, RelativeSizeSpan.class);
for (AbsoluteSizeSpan absSpan : absSpans) { for (AbsoluteSizeSpan absSpan : absSpans) {
newCueText.removeSpan(absSpan); cueText.removeSpan(absSpan);
} }
RelativeSizeSpan[] relSpans = cueText.getSpans(0, cueText.length(), RelativeSizeSpan.class);
for (RelativeSizeSpan relSpan : relSpans) { for (RelativeSizeSpan relSpan : relSpans) {
newCueText.removeSpan(relSpan); cueText.removeSpan(relSpan);
} }
cueText = newCueText;
} else { } else {
// Apply embedded styles & font size. // Apply embedded styles & font size.
if (cueTextSizePx > 0) { if (cueTextSizePx > 0) {
// Use a SpannableStringBuilder encompassing the whole cue text to apply the default // Use an AbsoluteSizeSpan encompassing the whole text to apply the default cueTextSizePx.
// cueTextSizePx. cueText.setSpan(
SpannableStringBuilder newCueText = new SpannableStringBuilder(cueText);
newCueText.setSpan(
new AbsoluteSizeSpan((int) cueTextSizePx), new AbsoluteSizeSpan((int) cueTextSizePx),
/* start= */ 0, /* start= */ 0,
/* end= */ newCueText.length(), /* end= */ cueText.length(),
Spanned.SPAN_PRIORITY); Spanned.SPAN_PRIORITY);
cueText = newCueText;
} }
} }
// Remove embedded font color to not destroy edges, otherwise it overrides edge color. // Remove embedded font color to not destroy edges, otherwise it overrides edge color.
SpannableStringBuilder cueTextEdge = new SpannableStringBuilder(cueText); SpannableStringBuilder cueTextEdge = new SpannableStringBuilder(cueText);
if (edgeType == CaptionStyleCompat.EDGE_TYPE_OUTLINE) { if (edgeType == CaptionStyleCompat.EDGE_TYPE_OUTLINE) {
int cueLength = cueTextEdge.length();
ForegroundColorSpan[] foregroundColorSpans = ForegroundColorSpan[] foregroundColorSpans =
cueTextEdge.getSpans(0, cueLength, ForegroundColorSpan.class); cueTextEdge.getSpans(0, cueTextEdge.length(), ForegroundColorSpan.class);
for (ForegroundColorSpan foregroundColorSpan : foregroundColorSpans) { for (ForegroundColorSpan foregroundColorSpan : foregroundColorSpans) {
cueTextEdge.removeSpan(foregroundColorSpan); cueTextEdge.removeSpan(foregroundColorSpan);
} }
@ -306,13 +305,8 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
if (Color.alpha(backgroundColor) > 0) { if (Color.alpha(backgroundColor) > 0) {
if (edgeType == CaptionStyleCompat.EDGE_TYPE_NONE if (edgeType == CaptionStyleCompat.EDGE_TYPE_NONE
|| edgeType == CaptionStyleCompat.EDGE_TYPE_DROP_SHADOW) { || edgeType == CaptionStyleCompat.EDGE_TYPE_DROP_SHADOW) {
SpannableStringBuilder newCueText = new SpannableStringBuilder(cueText); cueText.setSpan(
newCueText.setSpan( new BackgroundColorSpan(backgroundColor), 0, cueText.length(), Spanned.SPAN_PRIORITY);
new BackgroundColorSpan(backgroundColor),
0,
newCueText.length(),
Spanned.SPAN_PRIORITY);
cueText = newCueText;
} else { } else {
cueTextEdge.setSpan( cueTextEdge.setSpan(
new BackgroundColorSpan(backgroundColor), new BackgroundColorSpan(backgroundColor),
@ -499,4 +493,5 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
// equals methods, so we perform one explicitly here. // equals methods, so we perform one explicitly here.
return first == second || (first != null && first.equals(second)); return first == second || (first != null && first.equals(second));
} }
} }