loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify/avoid usages of onSeekProcessed in ExoPlayer code.

Browse Source 
This callback will be deprecated, so moving all usages to better callbacks.
Some usages are still remaining that are less straight-forward to update.

PiperOrigin-RevId: 303298834
This commit is contained in:
tonihei 2020-03-27 10:47:52 +00:00 committed by Oliver Woodman
parent 9be4c08459
commit c4a93b6420
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsCollector.java
View File

@ -522,6 +522,9 @@ public class AnalyticsCollector
@Override @Override
public final void onPositionDiscontinuity(@Player.DiscontinuityReason int reason) { public final void onPositionDiscontinuity(@Player.DiscontinuityReason int reason) {
if (reason == Player.DISCONTINUITY_REASON_SEEK) {
isSeeking = false;
}
mediaPeriodQueueTracker.onPositionDiscontinuity(Assertions.checkNotNull(player)); mediaPeriodQueueTracker.onPositionDiscontinuity(Assertions.checkNotNull(player));
EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime(); EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime();
for (AnalyticsListener listener : listeners) { for (AnalyticsListener listener : listeners) {
@ -553,12 +556,9 @@ public class AnalyticsCollector
@Override @Override
public final void onSeekProcessed() { public final void onSeekProcessed() {
if (isSeeking) { EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime();
isSeeking = false; for (AnalyticsListener listener : listeners) {
EventTime eventTime = generateCurrentPlayerMediaPeriodEventTime(); listener.onSeekProcessed(eventTime);
for (AnalyticsListener listener : listeners) {
listener.onSeekProcessed(eventTime);
}
} }
} }

5
library/core/src/main/java/com/google/android/exoplayer2/util/EventLogger.java
View File

@ -289,11 +289,6 @@ public class EventLogger implements AnalyticsListener {
logd("]"); logd("]");
} }
@Override
public void onSeekProcessed(EventTime eventTime) {
logd(eventTime, "seekProcessed");
}
@Override @Override
public void onMetadata(EventTime eventTime, Metadata metadata) { public void onMetadata(EventTime eventTime, Metadata metadata) {
logd("metadata [" + getEventTimeString(eventTime)); logd("metadata [" + getEventTimeString(eventTime));