loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comments for AudioGraph constructor

Browse Source 
Add /*effects=*/ at callsites of AudioGraph constructor.

PiperOrigin-RevId: 610741692
This commit is contained in:
Googler 2024-02-27 07:06:58 -08:00 committed by Copybara-Service
parent 94e0a27a81
commit c3aec4f19d
1 changed files with 25 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
libraries/transformer/src/test/java/androidx/media3/transformer/AudioGraphTest.java
View File

@ -46,11 +46,12 @@ public class AudioGraphTest {
@Test @Test
public void silentItem_outputsCorrectAmountOfBytes() throws Exception { public void silentItem_outputsCorrectAmountOfBytes() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
GraphInput input = audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000)); GraphInput input = audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000));
input.onMediaItemChanged( input.onMediaItemChanged(
FAKE_ITEM, /* durationUs= */ 3_000_000, /* trackFormat= */ null, /* isLast= */ true); FAKE_ITEM, /* durationUs= */ 3_000_000, /* decodedFormat= */ null, /* isLast= */ true);
int bytesOutput = drainAudioGraph(audioGraph); int bytesOutput = drainAudioGraph(audioGraph);
// 3 second stream with 50_000 frames per second. // 3 second stream with 50_000 frames per second.
@ -63,11 +64,12 @@ public class AudioGraphTest {
SonicAudioProcessor changeTo100000Hz = new SonicAudioProcessor(); SonicAudioProcessor changeTo100000Hz = new SonicAudioProcessor();
changeTo100000Hz.setOutputSampleRateHz(100_000); changeTo100000Hz.setOutputSampleRateHz(100_000);
AudioGraph audioGraph = AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of(changeTo100000Hz)); new AudioGraph(
new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of(changeTo100000Hz));
GraphInput input = audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000)); GraphInput input = audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000));
input.onMediaItemChanged( input.onMediaItemChanged(
FAKE_ITEM, /* durationUs= */ 3_000_000, /* trackFormat= */ null, /* isLast= */ true); FAKE_ITEM, /* durationUs= */ 3_000_000, /* decodedFormat= */ null, /* isLast= */ true);
int bytesOutput = drainAudioGraph(audioGraph); int bytesOutput = drainAudioGraph(audioGraph);
// 3 second stream with 100_000 frames per second. // 3 second stream with 100_000 frames per second.
@ -76,15 +78,17 @@ public class AudioGraphTest {
} }
@Test @Test
public void getOutputAudioFormat_afterInitialization_isNotSet() throws Exception { public void getOutputAudioFormat_afterInitialization_isNotSet() {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
assertThat(audioGraph.getOutputAudioFormat()).isEqualTo(AudioFormat.NOT_SET); assertThat(audioGraph.getOutputAudioFormat()).isEqualTo(AudioFormat.NOT_SET);
} }
@Test @Test
public void getOutputAudioFormat_afterRegisterInput_matchesInputFormat() throws Exception { public void getOutputAudioFormat_afterRegisterInput_matchesInputFormat() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(MONO_48000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(MONO_48000));
@ -93,7 +97,8 @@ public class AudioGraphTest {
@Test @Test
public void getOutputAudioFormat_afterConfigure_matchesConfiguredFormat() throws Exception { public void getOutputAudioFormat_afterConfigure_matchesConfiguredFormat() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
audioGraph.configure(/* mixerAudioFormat= */ SURROUND_50000); audioGraph.configure(/* mixerAudioFormat= */ SURROUND_50000);
@ -102,7 +107,8 @@ public class AudioGraphTest {
@Test @Test
public void registerInput_afterConfigure_doesNotChangeOutputFormat() throws Exception { public void registerInput_afterConfigure_doesNotChangeOutputFormat() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
audioGraph.configure(/* mixerAudioFormat= */ STEREO_44100); audioGraph.configure(/* mixerAudioFormat= */ STEREO_44100);
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000));
@ -113,7 +119,8 @@ public class AudioGraphTest {
@Test @Test
public void registerInput_afterRegisterInput_doesNotChangeOutputFormat() throws Exception { public void registerInput_afterRegisterInput_doesNotChangeOutputFormat() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000));
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(MONO_44100)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(MONO_44100));
@ -123,7 +130,8 @@ public class AudioGraphTest {
@Test @Test
public void registerInput_afterReset_changesOutputFormat() throws Exception { public void registerInput_afterReset_changesOutputFormat() throws Exception {
AudioGraph audioGraph = new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of()); AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of());
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(STEREO_48000));
audioGraph.reset(); audioGraph.reset();
@ -137,7 +145,8 @@ public class AudioGraphTest {
SonicAudioProcessor sonicAudioProcessor = new SonicAudioProcessor(); SonicAudioProcessor sonicAudioProcessor = new SonicAudioProcessor();
sonicAudioProcessor.setOutputSampleRateHz(48_000); sonicAudioProcessor.setOutputSampleRateHz(48_000);
AudioGraph audioGraph = AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of(sonicAudioProcessor)); new AudioGraph(
new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of(sonicAudioProcessor));
audioGraph.configure(/* mixerAudioFormat= */ SURROUND_50000); audioGraph.configure(/* mixerAudioFormat= */ SURROUND_50000);
@ -149,7 +158,8 @@ public class AudioGraphTest {
SonicAudioProcessor sonicAudioProcessor = new SonicAudioProcessor(); SonicAudioProcessor sonicAudioProcessor = new SonicAudioProcessor();
sonicAudioProcessor.setOutputSampleRateHz(48_000); sonicAudioProcessor.setOutputSampleRateHz(48_000);
AudioGraph audioGraph = AudioGraph audioGraph =
new AudioGraph(new DefaultAudioMixer.Factory(), ImmutableList.of(sonicAudioProcessor)); new AudioGraph(
new DefaultAudioMixer.Factory(), /* effects= */ ImmutableList.of(sonicAudioProcessor));
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000));
@ -164,7 +174,8 @@ public class AudioGraphTest {
changeTo48000Hz.setOutputSampleRateHz(48_000); changeTo48000Hz.setOutputSampleRateHz(48_000);
AudioGraph audioGraph = AudioGraph audioGraph =
new AudioGraph( new AudioGraph(
new DefaultAudioMixer.Factory(), ImmutableList.of(changeTo96000Hz, changeTo48000Hz)); new DefaultAudioMixer.Factory(),
/* effects= */ ImmutableList.of(changeTo96000Hz, changeTo48000Hz));
audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000)); audioGraph.registerInput(FAKE_ITEM, getPcmFormat(SURROUND_50000));