loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix 2 ErrorProneStyle findings:

Browse Source 
* @Reason is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs.
  (see go/java-style#s4.8.5-annotations)
* Curly braces should be used for inline Javadoc tags: {@code ...}
  (see http://go/bugpattern/InvalidInlineTag)

This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.

This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
Anything wrong with the signup? File a bug at go/clrobot-bug.

#codehealth

PiperOrigin-RevId: 404769260
This commit is contained in:
olly 2021-10-21 13:09:55 +01:00 committed by Oliver Woodman
parent bbe2cef740
commit bffe2f7bb3
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java
View File

@ -57,7 +57,7 @@ public final class ClippingMediaSource extends CompositeMediaSource<Void> {
public static final int REASON_START_EXCEEDS_END = 2; public static final int REASON_START_EXCEEDS_END = 2;
/** The reason clipping failed. */ /** The reason clipping failed. */
public final @Reason int reason; @Reason public final int reason;
/** @param reason The reason clipping failed. */ /** @param reason The reason clipping failed. */
public IllegalClippingException(@Reason int reason) { public IllegalClippingException(@Reason int reason) {

2
library/core/src/main/java/com/google/android/exoplayer2/source/SinglePeriodTimeline.java
View File

@ -147,7 +147,7 @@ public final class SinglePeriodTimeline extends Timeline {
* @param isDynamic Whether the window may change when the timeline is updated. * @param isDynamic Whether the window may change when the timeline is updated.
* @param useLiveConfiguration Whether the window is live and {@link MediaItem#liveConfiguration} * @param useLiveConfiguration Whether the window is live and {@link MediaItem#liveConfiguration}
* is used to configure live playback behaviour. * is used to configure live playback behaviour.
* @param manifest The manifest. May be (@code null}. * @param manifest The manifest. May be {@code null}.
* @param mediaItem A media item used for {@link Timeline.Window#mediaItem}. * @param mediaItem A media item used for {@link Timeline.Window#mediaItem}.
*/ */
public SinglePeriodTimeline( public SinglePeriodTimeline(