diff --git a/libraries/effect/src/main/java/androidx/media3/effect/OverlayEffect.java b/libraries/effect/src/main/java/androidx/media3/effect/OverlayEffect.java index 418790859d..49416f29e3 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/OverlayEffect.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/OverlayEffect.java @@ -19,6 +19,7 @@ import android.content.Context; import androidx.media3.common.VideoFrameProcessingException; import androidx.media3.common.util.UnstableApi; import com.google.common.collect.ImmutableList; +import java.util.List; /** * Applies a list of {@link TextureOverlay}s to a frame in FIFO order (the last overlay in the list @@ -36,10 +37,12 @@ public final class OverlayEffect implements GlEffect { /** * Creates a new instance for the given list of {@link TextureOverlay}s. * - * @param textureOverlays The {@link TextureOverlay}s to be blended into the frame. + * @param textureOverlays The {@link TextureOverlay}s to be blended into the frame. To modify the + * list of {@link TextureOverlay TextureOverlays}, one must recreate a new {@code + * OverlayEffect} with the updated list. */ - public OverlayEffect(ImmutableList textureOverlays) { - this.overlays = textureOverlays; + public OverlayEffect(List textureOverlays) { + this.overlays = ImmutableList.copyOf(textureOverlays); } @Override