From b3023ffe9adfbaaa69417c9ca01b0527e91e5b6f Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Wed, 8 Mar 2023 13:13:40 +0000 Subject: [PATCH] Effect: Remove todo to consider using Gamma 2.2 everywhere. Per testing, using gamma 2.2 everywhere resulted in undesirable color shifting. PiperOrigin-RevId: 515008279 --- .../java/androidx/media3/effect/DefaultVideoFrameProcessor.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java index 8cf3577965..f70e2b45fe 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java @@ -131,8 +131,6 @@ public final class DefaultVideoFrameProcessor implements VideoFrameProcessor { // Gamma 2.2 is used instead of SMPTE 170M for SDR, despite MediaFormat's // COLOR_TRANSFER_SDR_VIDEO being defined as SMPTE 170M. This is to match // other known tone-mapping behavior within the Android ecosystem. - // TODO(b/239735341): Consider migrating SDR outside tone-mapping from SMPTE - // 170M to gamma 2.2. checkArgument(inputColorInfo.colorSpace == C.COLOR_SPACE_BT2020); checkArgument(outputColorInfo.colorSpace != C.COLOR_SPACE_BT2020); checkArgument(ColorInfo.isTransferHdr(inputColorInfo));