diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 0d7c8057f5..8d1b81c5f5 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -116,6 +116,8 @@ to a click interaction ([#1590](https://github.com/androidx/media/issues/1590), [#184](https://github.com/androidx/media/issues/184)). + * Fix bug where the "None" choice in the text selection is not working if + there are app-defined text track selection preferences. * Downloads: * OkHttp Extension: * Cronet Extension: diff --git a/libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java b/libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java index f19d4e90b5..bc41557f8b 100644 --- a/libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java +++ b/libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java @@ -2136,7 +2136,8 @@ public class PlayerControlView extends FrameLayout { @Override public void onBindViewHolderAtZeroPosition(SubSettingViewHolder holder) { - // CC options include "Off" at the first position, which disables text rendering. + // CC options include "None" at the zero position, which disables text rendering except for + // forced text tracks that can't be disabled (and are also not shown in the selection list). holder.textView.setText(R.string.exo_track_selection_none); boolean isTrackSelectionOff = true; for (int i = 0; i < tracks.size(); i++) { @@ -2157,6 +2158,8 @@ public class PlayerControlView extends FrameLayout { .buildUpon() .clearOverridesOfType(C.TRACK_TYPE_TEXT) .setIgnoredTextSelectionFlags(~C.SELECTION_FLAG_FORCED) + .setPreferredTextLanguage(null) + .setPreferredTextRoleFlags(0) .build()); settingsWindow.dismiss(); }