From abb4d6ff70a9778d54c8fb85987498abe74d7d62 Mon Sep 17 00:00:00 2001 From: tonihei Date: Wed, 4 Jul 2018 03:58:23 -0700 Subject: [PATCH] Use correct generics type bounds for TransferListener in MediaSources. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203260699 --- .../android/exoplayer2/ext/ima/ImaAdsMediaSource.java | 2 +- .../google/android/exoplayer2/source/BaseMediaSource.java | 5 +++-- .../android/exoplayer2/source/ClippingMediaSource.java | 3 ++- .../android/exoplayer2/source/CompositeMediaSource.java | 6 +++--- .../android/exoplayer2/source/ConcatenatingMediaSource.java | 3 ++- .../android/exoplayer2/source/ExtractorMediaSource.java | 2 +- .../android/exoplayer2/source/LoopingMediaSource.java | 3 ++- .../com/google/android/exoplayer2/source/MediaSource.java | 3 ++- .../android/exoplayer2/source/MergingMediaSource.java | 3 ++- .../android/exoplayer2/source/SingleSampleMediaSource.java | 2 +- .../android/exoplayer2/source/ads/AdsMediaSource.java | 2 +- .../java/com/google/android/exoplayer2/ExoPlayerTest.java | 3 ++- .../android/exoplayer2/source/dash/DashMediaSource.java | 2 +- .../android/exoplayer2/source/hls/HlsMediaSource.java | 2 +- .../exoplayer2/source/smoothstreaming/SsMediaSource.java | 2 +- .../google/android/exoplayer2/testutil/FakeMediaSource.java | 3 ++- 16 files changed, 27 insertions(+), 19 deletions(-) diff --git a/extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsMediaSource.java b/extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsMediaSource.java index 4cae22487a..7c7810db7b 100644 --- a/extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsMediaSource.java +++ b/extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsMediaSource.java @@ -80,7 +80,7 @@ public final class ImaAdsMediaSource extends BaseMediaSource implements SourceIn public void prepareSourceInternal( final ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { adsMediaSource.prepareSource( player, isTopLevelSource, /* listener= */ this, mediaTransferListener); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/BaseMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/BaseMediaSource.java index da1a0aa2fd..1b64a1a797 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/BaseMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/BaseMediaSource.java @@ -19,6 +19,7 @@ import android.os.Handler; import android.support.annotation.Nullable; import com.google.android.exoplayer2.ExoPlayer; import com.google.android.exoplayer2.Timeline; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; import java.util.ArrayList; @@ -60,7 +61,7 @@ public abstract class BaseMediaSource implements MediaSource { protected abstract void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener); + @Nullable TransferListener mediaTransferListener); /** * Releases the source. This method is called exactly once after each call to {@link @@ -146,7 +147,7 @@ public abstract class BaseMediaSource implements MediaSource { ExoPlayer player, boolean isTopLevelSource, SourceInfoRefreshListener listener, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { Assertions.checkArgument(this.player == null || this.player == player); sourceInfoListeners.add(listener); if (this.player == null) { diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java index a6c34b643f..e0078be8a1 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java @@ -21,6 +21,7 @@ import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.ExoPlayer; import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; import java.io.IOException; @@ -215,7 +216,7 @@ public final class ClippingMediaSource extends CompositeMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); prepareChildSource(/* id= */ null, mediaSource); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/CompositeMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/CompositeMediaSource.java index 9ef655c7ed..4f1de2adcb 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/CompositeMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/CompositeMediaSource.java @@ -20,7 +20,7 @@ import android.support.annotation.CallSuper; import android.support.annotation.Nullable; import com.google.android.exoplayer2.ExoPlayer; import com.google.android.exoplayer2.Timeline; -import com.google.android.exoplayer2.source.MediaSourceEventListener.MediaLoadData; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; import com.google.android.exoplayer2.util.Util; @@ -38,7 +38,7 @@ public abstract class CompositeMediaSource extends BaseMediaSource { private @Nullable ExoPlayer player; private @Nullable Handler eventHandler; - private @Nullable TransferListener mediaTransferListener; + private @Nullable TransferListener mediaTransferListener; /** Create composite media source without child sources. */ protected CompositeMediaSource() { @@ -50,7 +50,7 @@ public abstract class CompositeMediaSource extends BaseMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { this.player = player; this.mediaTransferListener = mediaTransferListener; eventHandler = new Handler(); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/ConcatenatingMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/ConcatenatingMediaSource.java index 1a47390698..4db6f0b5d2 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/ConcatenatingMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/ConcatenatingMediaSource.java @@ -26,6 +26,7 @@ import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.source.ConcatenatingMediaSource.MediaSourceHolder; import com.google.android.exoplayer2.source.ShuffleOrder.DefaultShuffleOrder; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; import com.google.android.exoplayer2.util.Util; @@ -377,7 +378,7 @@ public class ConcatenatingMediaSource extends CompositeMediaSource mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); this.player = player; playerApplicationHandler = new Handler(player.getApplicationLooper()); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/ExtractorMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/ExtractorMediaSource.java index b96f0fee75..bfaec2f158 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/ExtractorMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/ExtractorMediaSource.java @@ -348,7 +348,7 @@ public final class ExtractorMediaSource extends BaseMediaSource public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { notifySourceInfoRefreshed(timelineDurationUs, /* isSeekable= */ false); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/LoopingMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/LoopingMediaSource.java index 9d58f9ad6e..76f04ba326 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/LoopingMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/LoopingMediaSource.java @@ -22,6 +22,7 @@ import com.google.android.exoplayer2.Player; import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.source.ShuffleOrder.UnshuffledShuffleOrder; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; @@ -64,7 +65,7 @@ public final class LoopingMediaSource extends CompositeMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); prepareChildSource(/* id= */ null, childSource); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/MediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/MediaSource.java index 61c2d0bcdf..1590235d15 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/MediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/MediaSource.java @@ -21,6 +21,7 @@ import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.ExoPlayer; import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import java.io.IOException; @@ -221,7 +222,7 @@ public interface MediaSource { ExoPlayer player, boolean isTopLevelSource, SourceInfoRefreshListener listener, - @Nullable TransferListener mediaTransferListener); + @Nullable TransferListener mediaTransferListener); /** * Throws any pending error encountered while loading or refreshing source information. diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/MergingMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/MergingMediaSource.java index 6c4fb6367e..f3299974b9 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/MergingMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/MergingMediaSource.java @@ -20,6 +20,7 @@ import android.support.annotation.Nullable; import com.google.android.exoplayer2.ExoPlayer; import com.google.android.exoplayer2.Timeline; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import java.io.IOException; import java.lang.annotation.Retention; @@ -101,7 +102,7 @@ public final class MergingMediaSource extends CompositeMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); for (int i = 0; i < mediaSources.length; i++) { prepareChildSource(i, mediaSources[i]); diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/SingleSampleMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/SingleSampleMediaSource.java index c873a42217..8e022e9ed7 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/SingleSampleMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/SingleSampleMediaSource.java @@ -272,7 +272,7 @@ public final class SingleSampleMediaSource extends BaseMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { refreshSourceInfo(timeline, /* manifest= */ null); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java b/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java index 36557fcd35..953c8f3760 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/source/ads/AdsMediaSource.java @@ -309,7 +309,7 @@ public final class AdsMediaSource extends CompositeMediaSource { public void prepareSourceInternal( final ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); Assertions.checkArgument(isTopLevelSource); final ComponentListener componentListener = new ComponentListener(); diff --git a/library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java b/library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java index c0d2a77d6b..7ae6c870a0 100644 --- a/library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java +++ b/library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java @@ -45,6 +45,7 @@ import com.google.android.exoplayer2.testutil.FakeTrackSelection; import com.google.android.exoplayer2.testutil.FakeTrackSelector; import com.google.android.exoplayer2.testutil.RobolectricUtil; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.TransferListener; import java.io.IOException; import java.util.ArrayList; @@ -233,7 +234,7 @@ public final class ExoPlayerTest { public synchronized void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { super.prepareSourceInternal(player, isTopLevelSource, mediaTransferListener); // We've queued a source info refresh on the playback thread's event queue. Allow the // test thread to prepare the player with the third source, and block this thread (the diff --git a/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java b/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java index 9fc874fca1..b90989825e 100644 --- a/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java +++ b/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java @@ -549,7 +549,7 @@ public final class DashMediaSource extends BaseMediaSource { public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { if (sideloadedManifest) { processManifest(false); } else { diff --git a/library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsMediaSource.java b/library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsMediaSource.java index 353452c431..f27342e587 100644 --- a/library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsMediaSource.java +++ b/library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsMediaSource.java @@ -371,7 +371,7 @@ public final class HlsMediaSource extends BaseMediaSource public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { EventDispatcher eventDispatcher = createEventDispatcher(/* mediaPeriodId= */ null); playlistTracker.start(manifestUri, eventDispatcher, /* listener= */ this); } diff --git a/library/smoothstreaming/src/main/java/com/google/android/exoplayer2/source/smoothstreaming/SsMediaSource.java b/library/smoothstreaming/src/main/java/com/google/android/exoplayer2/source/smoothstreaming/SsMediaSource.java index c1de4cc487..a5544cb286 100644 --- a/library/smoothstreaming/src/main/java/com/google/android/exoplayer2/source/smoothstreaming/SsMediaSource.java +++ b/library/smoothstreaming/src/main/java/com/google/android/exoplayer2/source/smoothstreaming/SsMediaSource.java @@ -466,7 +466,7 @@ public final class SsMediaSource extends BaseMediaSource public void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { if (sideloadedManifest) { manifestLoaderErrorThrower = new LoaderErrorThrower.Dummy(); processManifest(); diff --git a/testutils/src/main/java/com/google/android/exoplayer2/testutil/FakeMediaSource.java b/testutils/src/main/java/com/google/android/exoplayer2/testutil/FakeMediaSource.java index 5e30a45031..2e0bfcc9ab 100644 --- a/testutils/src/main/java/com/google/android/exoplayer2/testutil/FakeMediaSource.java +++ b/testutils/src/main/java/com/google/android/exoplayer2/testutil/FakeMediaSource.java @@ -35,6 +35,7 @@ import com.google.android.exoplayer2.source.MediaSourceEventListener.MediaLoadDa import com.google.android.exoplayer2.source.TrackGroup; import com.google.android.exoplayer2.source.TrackGroupArray; import com.google.android.exoplayer2.upstream.Allocator; +import com.google.android.exoplayer2.upstream.DataSource; import com.google.android.exoplayer2.upstream.DataSpec; import com.google.android.exoplayer2.upstream.TransferListener; import com.google.android.exoplayer2.util.Assertions; @@ -90,7 +91,7 @@ public class FakeMediaSource extends BaseMediaSource { public synchronized void prepareSourceInternal( ExoPlayer player, boolean isTopLevelSource, - @Nullable TransferListener mediaTransferListener) { + @Nullable TransferListener mediaTransferListener) { assertThat(preparedSource).isFalse(); preparedSource = true; releasedSource = false;