From a7a17dc2bb8bd76988ae32867ff1b8109fcccdb5 Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Tue, 26 Jul 2022 21:53:18 +0000 Subject: [PATCH] Rename findEncoderWithClosestFormatSupport. Just a misc nit, since I found the name a bit confusing, and figured findEncoderWithClosestSupportedFormat might be more descriptive. PiperOrigin-RevId: 463433646 --- .../androidx/media3/transformer/DefaultEncoderFactory.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java index e9ec7c0a27..33f50445c6 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/DefaultEncoderFactory.java @@ -224,7 +224,7 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { @Nullable VideoEncoderQueryResult encoderAndClosestFormatSupport = - findEncoderWithClosestFormatSupport( + findEncoderWithClosestSupportedFormat( format, requestedVideoEncoderSettings, videoEncoderSelector, @@ -342,14 +342,15 @@ public final class DefaultEncoderFactory implements Codec.EncoderFactory { } /** - * Finds an {@linkplain MediaCodecInfo encoder} that supports the requested format most closely. + * Finds an {@linkplain MediaCodecInfo encoder} that supports a format closest to the requested + * format. * *

Returns the {@linkplain MediaCodecInfo encoder} and the supported {@link Format} in a {@link * Pair}, or {@code null} if none is found. */ @RequiresNonNull("#1.sampleMimeType") @Nullable - private static VideoEncoderQueryResult findEncoderWithClosestFormatSupport( + private static VideoEncoderQueryResult findEncoderWithClosestSupportedFormat( Format requestedFormat, VideoEncoderSettings videoEncoderSettings, EncoderSelector encoderSelector,