From a4682cbff5585f98c38cf0253ae62e31753a444f Mon Sep 17 00:00:00 2001
From: OxygenCobalt <oxycblt@abstractr.net>
Date: Mon, 17 Jan 2022 10:34:49 -0700
Subject: [PATCH] Fix FlacStreamMetadata compile failure

Comment concatenation was accidentally not added previously, which
results in a testing failure.
---
 .../extractor/FlacStreamMetadata.java         | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/library/extractor/src/main/java/com/google/android/exoplayer2/extractor/FlacStreamMetadata.java b/library/extractor/src/main/java/com/google/android/exoplayer2/extractor/FlacStreamMetadata.java
index ae179a177b..905b7c7609 100644
--- a/library/extractor/src/main/java/com/google/android/exoplayer2/extractor/FlacStreamMetadata.java
+++ b/library/extractor/src/main/java/com/google/android/exoplayer2/extractor/FlacStreamMetadata.java
@@ -143,8 +143,7 @@ public final class FlacStreamMetadata {
         bitsPerSample,
         totalSamples,
         /* seekTable= */ null,
-        new Metadata(pictureFrames)
-          .copyWithAppendedEntriesFrom(VorbisUtil.parseVorbisComments(vorbisComments)));
+        concatenateVorbisMetadata(vorbisComments, pictureFrames));
   }
 
   private FlacStreamMetadata(
@@ -250,6 +249,22 @@ public final class FlacStreamMetadata {
     return metadata == null ? other : metadata.copyWithAppendedEntriesFrom(other);
   }
 
+  /** Returns */
+  @Nullable
+  private static Metadata concatenateVorbisMetadata(
+      List<String> vorbisComments,
+      List<PictureFrame> pictureFrames
+  ) {
+    @Nullable Metadata parsedVorbisComments = VorbisUtil.parseVorbisComments(vorbisComments);
+
+    if (parsedVorbisComments == null && pictureFrames.isEmpty()) {
+      return null;
+    }
+
+    return new Metadata(pictureFrames)
+        .copyWithAppendedEntriesFrom(parsedVorbisComments);
+  }
+
   /** Returns a copy of {@code this} with the seek table replaced by the one given. */
   public FlacStreamMetadata copyWithSeekTable(@Nullable SeekTable seekTable) {
     return new FlacStreamMetadata(