From a39a7f06cfcff466bddb1ba30e6adfc5b21d0fda Mon Sep 17 00:00:00 2001 From: sheenachhabra Date: Thu, 13 Jun 2024 08:04:45 -0700 Subject: [PATCH] Remove the code to restore current output position Muxer never uses latest output position but always writes to a specific location, so restoring its position does not add any value. PiperOrigin-RevId: 642996941 --- .../muxer/src/main/java/androidx/media3/muxer/Mp4Writer.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Writer.java b/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Writer.java index d7bb52a724..6225c36be3 100644 --- a/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Writer.java +++ b/libraries/muxer/src/main/java/androidx/media3/muxer/Mp4Writer.java @@ -322,7 +322,6 @@ import java.util.concurrent.atomic.AtomicBoolean; } private void updateMdatSize(long mdatSize) throws IOException { - long currentOutputPosition = output.position(); // The mdat box has a 64-bit length, so skip the box type (4 bytes) and the default box length // (4 bytes). output.position(mdatStart + BOX_HEADER_SIZE); @@ -330,8 +329,6 @@ import java.util.concurrent.atomic.AtomicBoolean; mdatSizeBuffer.putLong(mdatSize); mdatSizeBuffer.flip(); output.write(mdatSizeBuffer); - // Restore output position - output.position(currentOutputPosition); } private void doInterleave() throws IOException {