From 9cdf60d7913be78a18901a423900bdeae62e3b7c Mon Sep 17 00:00:00 2001 From: kimvde Date: Fri, 31 Mar 2023 12:08:42 +0100 Subject: [PATCH] Fix emulator tests flakiness Releasing the player once a sequence has ended seems to make our emulator tests flaky. Comment out until we find the cause. The player will still be released from TransformerInternal, when the export ends. PiperOrigin-RevId: 520886181 --- .../java/androidx/media3/transformer/SequenceAssetLoader.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/SequenceAssetLoader.java b/libraries/transformer/src/main/java/androidx/media3/transformer/SequenceAssetLoader.java index 5c3e6cbf76..cd0558932b 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/SequenceAssetLoader.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/SequenceAssetLoader.java @@ -501,7 +501,9 @@ import java.util.concurrent.atomic.AtomicInteger; } private void release() { - handler.post(SequenceAssetLoader.this::release); + // TODO(b/276415739): releasing the player earlier causes more release timeouts on emulator + // tests. Figure out what the cause is and uncomment the line below once fixed. + // handler.post(SequenceAssetLoader.this::release); } } }