loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid ImageReader frame drops in EffectPlaybackPixelTest

Browse Source 
If this doesn't work, we could make this test resilient to frame drops
by only comparing the frames that weren't dropped.

PiperOrigin-RevId: 676294944
This commit is contained in:
kimvde 2024-09-19 00:15:32 -07:00 committed by Copybara-Service
parent ecb0024a0b
commit 980f24d906
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/performance/EffectPlaybackPixelTest.java
View File

@ -51,7 +51,9 @@ import androidx.media3.exoplayer.Renderer;
import androidx.media3.exoplayer.util.EventLogger;
import androidx.media3.exoplayer.video.MediaCodecVideoRenderer;
import androidx.media3.test.utils.BitmapPixelTestUtil;
import androidx.media3.transformer.SurfaceTestActivity;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.rules.ActivityScenarioRule;
import androidx.test.platform.app.InstrumentationRegistry;
import com.google.common.collect.ImmutableList;
import java.util.ArrayList;
@ -165,6 +167,12 @@ public class EffectPlaybackPixelTest {
/** Playback test for {@link Effect}-enabled playback. */
public static class PlaybackTest {
@Rule public final TestName testName = new TestName();
// Force the test to run in foreground to make it faster and avoid ImageReader frame drops.
@Rule
public ActivityScenarioRule<SurfaceTestActivity> rule =
new ActivityScenarioRule<>(SurfaceTestActivity.class);
private final Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation();
private @MonotonicNonNull ExoPlayer player;
private @MonotonicNonNull ImageReader outputImageReader;
@ -192,14 +200,14 @@ public class EffectPlaybackPixelTest {
AtomicInteger renderedFramesCount = new AtomicInteger();
ConditionVariable playerEnded = new ConditionVariable();
ConditionVariable readAllOutputFrames = new ConditionVariable();
// Setting maxImages=5 ensures image reader gets all rendered frames from VideoFrameProcessor.
// Using maxImages=5 runs successfully on a Pixel3.
// Setting maxImages=10 ensures image reader gets all rendered frames from
// VideoFrameProcessor. Using maxImages=10 runs successfully on a Pixel3.
outputImageReader =
ImageReader.newInstance(
MP4_ASSET.videoFormat.width,
MP4_ASSET.videoFormat.height,
PixelFormat.RGBA_8888,
/* maxImages= */ 5);
/* maxImages= */ 10);
instrumentation.runOnMainSync(
() -> {
@ -287,14 +295,14 @@ public class EffectPlaybackPixelTest {
AtomicInteger renderedFramesCount = new AtomicInteger();
ConditionVariable playerEnded = new ConditionVariable();
ConditionVariable readAllOutputFrames = new ConditionVariable();
// Setting maxImages=5 ensures image reader gets all rendered frames from VideoFrameProcessor.
// Using maxImages=5 runs successfully on a Pixel3.
// Setting maxImages=10 ensures image reader gets all rendered frames from
// VideoFrameProcessor. Using maxImages=10 runs successfully on a Pixel3.
outputImageReader =
ImageReader.newInstance(
MP4_ASSET.videoFormat.width,
MP4_ASSET.videoFormat.height,
PixelFormat.RGBA_8888,
/* maxImages= */ 5);
/* maxImages= */ 10);
instrumentation.runOnMainSync(
() -> {