From 95c13819af1bc2259d90bac3eef2364cd0581af0 Mon Sep 17 00:00:00 2001 From: samrobinson Date: Tue, 14 May 2024 03:06:28 -0700 Subject: [PATCH] Log DebugTraceUtil events to logcat as they occur. PiperOrigin-RevId: 633512813 --- .../media3/effect/DebugTraceUtil.java | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/DebugTraceUtil.java b/libraries/effect/src/main/java/androidx/media3/effect/DebugTraceUtil.java index 4d7ca07f5e..6ef451bc72 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/DebugTraceUtil.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/DebugTraceUtil.java @@ -25,6 +25,7 @@ import androidx.annotation.GuardedBy; import androidx.annotation.Nullable; import androidx.annotation.StringDef; import androidx.media3.common.C; +import androidx.media3.common.util.Log; import androidx.media3.common.util.SystemClock; import androidx.media3.common.util.UnstableApi; import androidx.media3.common.util.Util; @@ -50,11 +51,22 @@ public final class DebugTraceUtil { /** * Whether to store tracing events for debug logging. Should be set to {@code true} for testing - * and debugging purposes only, before running transformer. + * and debugging purposes only. */ @SuppressWarnings("NonFinalStaticField") // Only for debugging/testing. public static boolean enableTracing = false; + /** + * Whether to {@linkplain Log#d(String, String) log} tracing events to the logcat as they occur. + * Should be set to {@code true} for testing and debugging purposes only. + * + *

Note that enabling this can add a large amount of logcat lines. + * + *

Requires {@link #enableTracing} to be true. + */ + @SuppressWarnings("NonFinalStaticField") // Only for debugging/testing. + public static boolean enableTracesInLogcat = false; + /** Events logged by {@link #logEvent}. */ @Documented @Retention(RetentionPolicy.SOURCE) @@ -256,7 +268,11 @@ public final class DebugTraceUtil { } EventLogger logger = events.get(event); String extra = Util.formatInvariant(extraFormat, extraArgs); - logger.addLog(new EventLog(presentationTimeUs, eventTimeMs, extra)); + EventLog eventLog = new EventLog(presentationTimeUs, eventTimeMs, extra); + logger.addLog(eventLog); + if (enableTracesInLogcat) { + Log.d("DebugTrace-" + component, event + ": " + eventLog); + } } /**