loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add TODOs for registerReceiver calls without flag

Browse Source 
PiperOrigin-RevId: 461165173
This commit is contained in:
olly 2022-07-15 10:34:53 +00:00 committed by Rohit Singh
parent be27daebc4
commit 9271572e95
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libraries/session/src/main/java/androidx/media3/session/MediaSessionImpl.java
View File

@ -210,6 +210,7 @@ import org.checkerframework.checker.initialization.qual.Initialized;
broadcastReceiver = new MediaButtonReceiver(); broadcastReceiver = new MediaButtonReceiver();
IntentFilter filter = new IntentFilter(Intent.ACTION_MEDIA_BUTTON); IntentFilter filter = new IntentFilter(Intent.ACTION_MEDIA_BUTTON);
filter.addDataScheme(castNonNull(sessionUri.getScheme())); filter.addDataScheme(castNonNull(sessionUri.getScheme()));
// TODO(b/197817693): Explicitly indicate whether the receiver should be exported.
context.registerReceiver(broadcastReceiver, filter); context.registerReceiver(broadcastReceiver, filter);
} else { } else {
// Has MediaSessionService to revive playback after it's dead. // Has MediaSessionService to revive playback after it's dead.

1
libraries/ui/src/main/java/androidx/media3/ui/PlayerNotificationManager.java
View File

@ -1164,6 +1164,7 @@ public class PlayerNotificationManager {
Notification notification = builder.build(); Notification notification = builder.build();
notificationManager.notify(notificationId, notification); notificationManager.notify(notificationId, notification);
if (!isNotificationStarted) { if (!isNotificationStarted) {
// TODO(b/197817693): Explicitly indicate whether the receiver should be exported.
context.registerReceiver(notificationBroadcastReceiver, intentFilter); context.registerReceiver(notificationBroadcastReceiver, intentFilter);
} }
if (notificationListener != null) { if (notificationListener != null) {