loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Assert file exists before trying to re-decode for test assertions.

Browse Source 
PiperOrigin-RevId: 635748820
This commit is contained in:
samrobinson 2024-05-21 03:39:28 -07:00 committed by Copybara-Service
parent 2585051294
commit 8e4d82b012
5 changed files with 40 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libraries/transformer/src/androidTest/java/androidx/media3/transformer/TransformerMultiSequenceCompositionTest.java
View File

@ -108,7 +108,8 @@ public final class TransformerMultiSequenceCompositionTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpected(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -142,7 +143,8 @@ public final class TransformerMultiSequenceCompositionTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpected(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -198,7 +200,8 @@ public final class TransformerMultiSequenceCompositionTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpected(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}

18
libraries/transformer/src/androidTest/java/androidx/media3/transformer/TransformerSequenceEffectTest.java
View File

@ -140,7 +140,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -437,7 +438,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -460,7 +462,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -484,7 +487,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -509,7 +513,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}
@ -534,7 +539,8 @@ public final class TransformerSequenceEffectTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertBitmapsMatchExpectedAndSave(
extractBitmapsFromVideo(context, checkNotNull(result.filePath)), testId);
}

15
libraries/transformer/src/androidTest/java/androidx/media3/transformer/TransformerUltraHdrTest.java
View File

@ -94,7 +94,8 @@ public final class TransformerUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}
@ -115,7 +116,8 @@ public final class TransformerUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}
@ -137,7 +139,8 @@ public final class TransformerUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}
@ -152,7 +155,8 @@ public final class TransformerUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}
@ -169,7 +173,8 @@ public final class TransformerUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}

12
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TransformerMhUltraHdrTest.java
View File

@ -83,7 +83,8 @@ public final class TransformerMhUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
ColorInfo colorInfo =
retrieveTrackFormat(context, result.filePath, C.TRACK_TYPE_VIDEO).colorInfo;
assertThat(colorInfo.colorSpace).isEqualTo(C.COLOR_SPACE_BT2020);
@ -104,7 +105,8 @@ public final class TransformerMhUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
ColorInfo colorInfo =
retrieveTrackFormat(context, result.filePath, C.TRACK_TYPE_VIDEO).colorInfo;
assertThat(colorInfo.colorSpace).isEqualTo(C.COLOR_SPACE_BT2020);
@ -125,7 +127,8 @@ public final class TransformerMhUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
ColorInfo colorInfo =
retrieveTrackFormat(context, result.filePath, C.TRACK_TYPE_VIDEO).colorInfo;
assertThat(colorInfo.colorSpace).isEqualTo(C.COLOR_SPACE_BT2020);
@ -146,7 +149,8 @@ public final class TransformerMhUltraHdrTest {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
assertSdrColors(context, result.filePath);
}

6
libraries/transformer/src/androidTest/java/androidx/media3/transformer/mh/TransformerSequenceEffectTestWithHdr.java
View File

@ -107,7 +107,8 @@ public final class TransformerSequenceEffectTestWithHdr {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
// Expected bitmaps were generated on the Pixel 7 Pro, because emulators don't
// support decoding HDR.
assertBitmapsMatchExpectedAndSave(
@ -185,7 +186,8 @@ public final class TransformerSequenceEffectTestWithHdr {
.build()
.run(testId, composition);
assertThat(result.filePath).isNotNull();
assertThat(result.filePath).isNotEmpty();
assertThat(result.exportResult.fileSizeBytes).isGreaterThan(0);
// Expected bitmaps were generated on the Samsung S22 Ultra (US), because emulators don't
// support decoding HDR, and the Pixel 7 Pro does support HDR editing.
assertBitmapsMatchExpectedAndSave(