loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some deprecated Player methods

Browse Source 
PiperOrigin-RevId: 372981744
This commit is contained in:
olly 2021-05-10 20:03:02 +01:00 committed by Oliver Woodman
parent d282ad25c1
commit 89cfa4df32
3 changed files with 3 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
RELEASENOTES.md
View File

@ -3,6 +3,9 @@
### dev-v2 (not yet released) ### dev-v2 (not yet released)
* Remove deprecated symbols: * Remove deprecated symbols:
* Remove `Player.getPlaybackError`. Use `Player.getPlayerError` instead.
* Remove `Player.getCurrentTag`. Use `Player.getCurrentMediaItem` and
`MediaIteam.PlaybackProperties.tag` instead.
* Remove `PlaybackPreparer`. UI components that previously had * Remove `PlaybackPreparer`. UI components that previously had
`setPlaybackPreparer` methods will now call `Player.prepare` by default. `setPlaybackPreparer` methods will now call `Player.prepare` by default.
If this behavior is sufficient, use of `PlaybackPreparer` can be removed If this behavior is sufficient, use of `PlaybackPreparer` can be removed

26
library/common/src/main/java/com/google/android/exoplayer2/BasePlayer.java
View File

@ -86,14 +86,6 @@ public abstract class BasePlayer implements Player {
return getAvailableCommands().contains(command); return getAvailableCommands().contains(command);
} }
/** @deprecated Use {@link #getPlayerError()} instead. */
@Deprecated
@Override
@Nullable
public final ExoPlaybackException getPlaybackError() {
return getPlayerError();
}
@Override @Override
public final void play() { public final void play() {
setPlayWhenReady(true); setPlayWhenReady(true);
@ -180,24 +172,6 @@ public abstract class BasePlayer implements Player {
getCurrentWindowIndex(), getRepeatModeForNavigation(), getShuffleModeEnabled()); getCurrentWindowIndex(), getRepeatModeForNavigation(), getShuffleModeEnabled());
} }
/**
* @deprecated Use {@link #getCurrentMediaItem()} and {@link MediaItem.PlaybackProperties#tag}
* instead.
*/
@Deprecated
@Override
@Nullable
public final Object getCurrentTag() {
Timeline timeline = getCurrentTimeline();
if (timeline.isEmpty()) {
return null;
}
@Nullable
MediaItem.PlaybackProperties playbackProperties =
timeline.getWindow(getCurrentWindowIndex(), window).mediaItem.playbackProperties;
return playbackProperties != null ? playbackProperties.tag : null;
}
@Override @Override
@Nullable @Nullable
public final MediaItem getCurrentMediaItem() { public final MediaItem getCurrentMediaItem() {

13
library/common/src/main/java/com/google/android/exoplayer2/Player.java
View File

@ -1337,11 +1337,6 @@ public interface Player {
@Nullable @Nullable
ExoPlaybackException getPlayerError(); ExoPlaybackException getPlayerError();
/** @deprecated Use {@link #getPlayerError()} instead. */
@Deprecated
@Nullable
ExoPlaybackException getPlaybackError();
/** /**
* Resumes playback as soon as {@link #getPlaybackState()} == {@link #STATE_READY}. Equivalent to * Resumes playback as soon as {@link #getPlaybackState()} == {@link #STATE_READY}. Equivalent to
* {@code setPlayWhenReady(true)}. * {@code setPlayWhenReady(true)}.
@ -1630,14 +1625,6 @@ public interface Player {
*/ */
int getPreviousWindowIndex(); int getPreviousWindowIndex();
/**
* @deprecated Use {@link #getCurrentMediaItem()} and {@link MediaItem.PlaybackProperties#tag}
* instead.
*/
@Deprecated
@Nullable
Object getCurrentTag();
/** /**
* Returns the media item of the current window in the timeline. May be null if the timeline is * Returns the media item of the current window in the timeline. May be null if the timeline is
* empty. * empty.