From 857c18b2e9a1757d10139e776ebe0dad5f114c1a Mon Sep 17 00:00:00 2001 From: tonihei Date: Fri, 28 Jan 2022 10:01:15 +0000 Subject: [PATCH] Remove opt-out for suppressing wrong thread usage error. Enforcing the correct thread usage has been enabled since 2.13.0. Opting-out of this enforement is dangerous as it can hide very hard to debug bugs. PiperOrigin-RevId: 424815808 --- .../java/androidx/media3/exoplayer/ExoPlayer.java | 14 -------------- .../androidx/media3/exoplayer/SimpleExoPlayer.java | 4 +--- .../androidx/media3/test/utils/StubExoPlayer.java | 6 ------ 3 files changed, 1 insertion(+), 23 deletions(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java index 7145b4536b..1b770f014e 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java @@ -1547,20 +1547,6 @@ public interface ExoPlayer extends Player { @UnstableApi void setPriorityTaskManager(@Nullable PriorityTaskManager priorityTaskManager); - /** - * Sets whether the player should throw an {@link IllegalStateException} when methods are called - * from a thread other than the one associated with {@link #getApplicationLooper()}. - * - *

The default is {@code true} and this method will be removed in the future. - * - * @param throwsWhenUsingWrongThread Whether to throw when methods are called from a wrong thread. - * @deprecated Disabling the enforcement can result in hard-to-detect bugs. Do not use this method - * except to ease the transition while wrong thread access problems are fixed. - */ - @UnstableApi - @Deprecated - void setThrowsWhenUsingWrongThread(boolean throwsWhenUsingWrongThread); - /** * Sets whether audio offload scheduling is enabled. If enabled, ExoPlayer's main loop will run as * rarely as possible when playing an audio stream using audio offload. diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/SimpleExoPlayer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/SimpleExoPlayer.java index ca19aa490a..09c0a351b8 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/SimpleExoPlayer.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/SimpleExoPlayer.java @@ -1552,9 +1552,7 @@ public class SimpleExoPlayer extends BasePlayer streamVolumeManager.setMuted(muted); } - @Deprecated - @Override - public void setThrowsWhenUsingWrongThread(boolean throwsWhenUsingWrongThread) { + /* package */ void setThrowsWhenUsingWrongThread(boolean throwsWhenUsingWrongThread) { this.throwsWhenUsingWrongThread = throwsWhenUsingWrongThread; } diff --git a/libraries/test_utils/src/main/java/androidx/media3/test/utils/StubExoPlayer.java b/libraries/test_utils/src/main/java/androidx/media3/test/utils/StubExoPlayer.java index a875c3ab7f..7f9471a1b6 100644 --- a/libraries/test_utils/src/main/java/androidx/media3/test/utils/StubExoPlayer.java +++ b/libraries/test_utils/src/main/java/androidx/media3/test/utils/StubExoPlayer.java @@ -359,12 +359,6 @@ public class StubExoPlayer extends StubPlayer implements ExoPlayer { throw new UnsupportedOperationException(); } - @Deprecated - @Override - public void setThrowsWhenUsingWrongThread(boolean throwsWhenUsingWrongThread) { - throw new UnsupportedOperationException(); - } - @Override public void experimentalSetOffloadSchedulingEnabled(boolean offloadSchedulingEnabled) { throw new UnsupportedOperationException();