loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Dackka parameter name error in Gav1Decoder and VpxDecoder

Browse Source 
These aren't caught by presubmit because the classes are annotated
`@VisibleForTesting` and are therefore stripped out by Metalava. However
Metalava doesn't run when we're generating javadoc for real.

#minor-release

PiperOrigin-RevId: 487476260
This commit is contained in:
ibaker 2022-11-10 10:19:01 +00:00 committed by microkatz
parent 3ab881351e
commit 742da7f49a
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/decoder_av1/src/main/java/androidx/media3/decoder/av1/Gav1Decoder.java
View File

@ -138,13 +138,13 @@ public final class Gav1Decoder
}
@Override
protected void releaseOutputBuffer(VideoDecoderOutputBuffer buffer) {
protected void releaseOutputBuffer(VideoDecoderOutputBuffer outputBuffer) {
// Decode only frames do not acquire a reference on the internal decoder buffer and thus do not
// require a call to gav1ReleaseFrame.
if (buffer.mode == C.VIDEO_OUTPUT_MODE_SURFACE_YUV && !buffer.isDecodeOnly()) {
gav1ReleaseFrame(gav1DecoderContext, buffer);
if (outputBuffer.mode == C.VIDEO_OUTPUT_MODE_SURFACE_YUV && !outputBuffer.isDecodeOnly()) {
gav1ReleaseFrame(gav1DecoderContext, outputBuffer);
}
super.releaseOutputBuffer(buffer);
super.releaseOutputBuffer(outputBuffer);
}
/**

8
libraries/decoder_vp9/src/main/java/androidx/media3/decoder/vp9/VpxDecoder.java
View File

@ -101,13 +101,13 @@ public final class VpxDecoder
}
@Override
protected void releaseOutputBuffer(VideoDecoderOutputBuffer buffer) {
protected void releaseOutputBuffer(VideoDecoderOutputBuffer outputBuffer) {
// Decode only frames do not acquire a reference on the internal decoder buffer and thus do not
// require a call to vpxReleaseFrame.
if (outputMode == C.VIDEO_OUTPUT_MODE_SURFACE_YUV && !buffer.isDecodeOnly()) {
vpxReleaseFrame(vpxDecContext, buffer);
if (outputMode == C.VIDEO_OUTPUT_MODE_SURFACE_YUV && !outputBuffer.isDecodeOnly()) {
vpxReleaseFrame(vpxDecContext, outputBuffer);
}
super.releaseOutputBuffer(buffer);
super.releaseOutputBuffer(outputBuffer);
}
@Override