Conditionally output captured data in CapturingRenderersFactory

This change makes capturing components in CapturingRenderersFactory
to dump data only they have previously captured any. This is so we can
extend the CapturingRenderersFactory with more renderers that do not
capture data in pre-existing tests and we don't have to change the
golden files.

PiperOrigin-RevId: 561973645
This commit is contained in:
christosts 2023-09-01 09:23:55 -07:00 committed by Copybara-Service
parent 502504fd47
commit 70ad637e52
21 changed files with 248 additions and 273 deletions

View File

@ -1,3 +1,4 @@
AudioSink:
buffer count = 29 buffer count = 29
discontinuity: discontinuity:
config: config:

View File

@ -1,3 +1,4 @@
AudioSink:
buffer count = 29 buffer count = 29
discontinuity: discontinuity:
config: config:

View File

@ -1,3 +1,4 @@
AudioSink:
buffer count = 14 buffer count = 14
config: config:
pcmEncoding = 2 pcmEncoding = 2

View File

@ -1,5 +1,3 @@
AudioSink:
buffer count = 0
MetadataOutput: MetadataOutput:
Metadata[0]: Metadata[0]:
presentationTimeUs = 100000 presentationTimeUs = 100000

View File

@ -1,5 +1,3 @@
AudioSink:
buffer count = 0
MetadataOutput: MetadataOutput:
Metadata[0]: Metadata[0]:
presentationTimeUs = 100000 presentationTimeUs = 100000

View File

@ -504,5 +504,3 @@ MediaCodecAdapter (exotest.video.avc):
timeUs = 1000002959000 timeUs = 1000002959000
size = 171 size = 171
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -56,5 +56,3 @@ MediaCodecAdapter (exotest.video.avc):
timeUs = 1000000492011 timeUs = 1000000492011
size = 2400 size = 2400
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -1,5 +1,3 @@
AudioSink:
buffer count = 0
ImageOutput: ImageOutput:
rendered image count = 1 rendered image count = 1
image output #1: image output #1:

View File

@ -1,2 +0,0 @@
AudioSink:
buffer count = 0

View File

@ -1,2 +0,0 @@
AudioSink:
buffer count = 0

View File

@ -28,5 +28,3 @@ MediaCodecAdapter (exotest.video.avc):
timeUs = 1000000133466 timeUs = 1000000133466
size = 442 size = 442
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -28,5 +28,3 @@ MediaCodecAdapter (exotest.video.avc):
timeUs = 1000000100100 timeUs = 1000000100100
size = 254 size = 254
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -1,2 +0,0 @@
AudioSink:
buffer count = 0

View File

@ -1,2 +0,0 @@
AudioSink:
buffer count = 0

View File

@ -217,5 +217,3 @@ MediaCodecAdapter (exotest.video.vp9):
timeUs = 1000000968000 timeUs = 1000000968000
size = 547 size = 547
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -581,5 +581,3 @@ MediaCodecAdapter (exotest.video.vp9):
timeUs = 1000002703000 timeUs = 1000002703000
size = 1427 size = 1427
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -364,5 +364,3 @@ MediaCodecAdapter (exotest.video.vp9):
timeUs = 1000002000000 timeUs = 1000002000000
size = 1477 size = 1477
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -567,5 +567,3 @@ MediaCodecAdapter (exotest.video.vp9):
timeUs = 1000002961000 timeUs = 1000002961000
size = 807 size = 807
rendered = true rendered = true
AudioSink:
buffer count = 0

View File

@ -88,10 +88,14 @@ public final class CapturingAudioSink extends ForwardingAudioSink implements Dum
@Override @Override
public void dump(Dumper dumper) { public void dump(Dumper dumper) {
dumper.add("buffer count", bufferCount); if (interceptedData.isEmpty()) {
return;
}
dumper.startBlock("AudioSink").add("buffer count", bufferCount);
for (int i = 0; i < interceptedData.size(); i++) { for (int i = 0; i < interceptedData.size(); i++) {
interceptedData.get(i).dump(dumper); interceptedData.get(i).dump(dumper);
} }
dumper.endBlock();
} }
private static final class DumpableConfiguration implements Dumper.Dumpable { private static final class DumpableConfiguration implements Dumper.Dumpable {

View File

@ -59,9 +59,11 @@ public final class CapturingImageOutput implements Dumpable, ImageOutput {
@Override @Override
public void dump(Dumper dumper) { public void dump(Dumper dumper) {
dumper.startBlock("ImageOutput");
dumper.add("rendered image count", imageCount); dumper.add("rendered image count", imageCount);
for (Dumpable dumpable : renderedBitmaps) { for (Dumpable dumpable : renderedBitmaps) {
dumpable.dump(dumper); dumpable.dump(dumper);
} }
dumper.endBlock();
} }
} }

View File

@ -157,13 +157,9 @@ public class CapturingRenderersFactory implements RenderersFactory, Dumper.Dumpa
@Override @Override
public void dump(Dumper dumper) { public void dump(Dumper dumper) {
mediaCodecAdapterFactory.dump(dumper); mediaCodecAdapterFactory.dump(dumper);
dumper.startBlock("AudioSink");
audioSink.dump(dumper); audioSink.dump(dumper);
dumper.endBlock();
if (addImageRenderer) { if (addImageRenderer) {
dumper.startBlock("ImageOutput");
imageOutput.dump(dumper); imageOutput.dump(dumper);
dumper.endBlock();
} }
} }