loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Set instead of a List for metadata collection

Browse Source 
All metadata entries are supposed to be unique, so Set is more appropriate.

PiperOrigin-RevId: 646907916
This commit is contained in:
sheenachhabra 2024-06-26 05:26:53 -07:00 committed by Copybara-Service
parent efbd522df9
commit 6fc0243106
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/muxer/src/main/java/androidx/media3/muxer/MetadataCollector.java
View File

@ -23,22 +23,22 @@ import androidx.media3.container.Mp4LocationData;
import androidx.media3.container.Mp4OrientationData; import androidx.media3.container.Mp4OrientationData;
import androidx.media3.container.Mp4TimestampData; import androidx.media3.container.Mp4TimestampData;
import androidx.media3.container.XmpData; import androidx.media3.container.XmpData;
import java.util.ArrayList; import java.util.HashSet;
import java.util.List; import java.util.Set;
import org.checkerframework.checker.nullness.qual.MonotonicNonNull; import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
/** Collects and provides metadata: location, FPS, XMP data, etc. */ /** Collects and provides metadata: location, FPS, XMP data, etc. */
/* package */ final class MetadataCollector { /* package */ final class MetadataCollector {
public Mp4OrientationData orientationData; public Mp4OrientationData orientationData;
public @MonotonicNonNull Mp4LocationData locationData; public @MonotonicNonNull Mp4LocationData locationData;
public List<MdtaMetadataEntry> metadataEntries; public Set<MdtaMetadataEntry> metadataEntries;
public Mp4TimestampData timestampData; public Mp4TimestampData timestampData;
public @MonotonicNonNull XmpData xmpData; public @MonotonicNonNull XmpData xmpData;
/** Creates an instance. */ /** Creates an instance. */
public MetadataCollector() { public MetadataCollector() {
orientationData = new Mp4OrientationData(/* orientation= */ 0); orientationData = new Mp4OrientationData(/* orientation= */ 0);
metadataEntries = new ArrayList<>(); metadataEntries = new HashSet<>();
long currentTimeInMp4TimeSeconds = unixTimeToMp4TimeSeconds(System.currentTimeMillis()); long currentTimeInMp4TimeSeconds = unixTimeToMp4TimeSeconds(System.currentTimeMillis());
timestampData = timestampData =
new Mp4TimestampData( new Mp4TimestampData(