From 61a0bf3f8c57c8099279ac7ebcecaa0ff7e898fc Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 17 Jan 2022 11:09:39 +0000 Subject: [PATCH] Add an anchor tag for the IMA compat URL in ImaAdsLoader javadoc The naked URL is not hyperlinked by the javadoc compiler, meaning a user is forced to awkwardly copy it into the address bar of their browser: https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.html #minor-release PiperOrigin-RevId: 422320571 --- .../media3/exoplayer/ima/ImaAdsLoader.java | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libraries/exoplayer_ima/src/main/java/androidx/media3/exoplayer/ima/ImaAdsLoader.java b/libraries/exoplayer_ima/src/main/java/androidx/media3/exoplayer/ima/ImaAdsLoader.java index 3c25159642..c96f8723df 100644 --- a/libraries/exoplayer_ima/src/main/java/androidx/media3/exoplayer/ima/ImaAdsLoader.java +++ b/libraries/exoplayer_ima/src/main/java/androidx/media3/exoplayer/ima/ImaAdsLoader.java @@ -72,14 +72,15 @@ import java.util.Set; * #setPlayer(Player)}. If the ads loader is no longer required, it must be released by calling * {@link #release()}. * - *

See https://developers.google.com/interactive-media-ads/docs/sdks/android/compatibility for - * information on compatible ad tag formats. Pass the ad tag URI when setting media item playback - * properties (if using the media item API) or as a {@link DataSpec} when constructing the {@link - * AdsMediaSource} (if using media sources directly). For the latter case, please note that this - * implementation delegates loading of the data spec to the IMA SDK, so range and headers - * specifications will be ignored in ad tag URIs. Literal ads responses can be encoded as data - * scheme data specs, for example, by constructing the data spec using a URI generated via {@link - * Util#getDataUriForString(String, String)}. + *

See IMA's + * Support and compatibility page for information on compatible ad tag formats. Pass the ad tag + * URI when setting media item playback properties (if using the media item API) or as a {@link + * DataSpec} when constructing the {@link AdsMediaSource} (if using media sources directly). For the + * latter case, please note that this implementation delegates loading of the data spec to the IMA + * SDK, so range and headers specifications will be ignored in ad tag URIs. Literal ads responses + * can be encoded as data scheme data specs, for example, by constructing the data spec using a URI + * generated via {@link Util#getDataUriForString(String, String)}. * *

The IMA SDK can report obstructions to the ad view for accurate viewability measurement. This * means that any overlay views that obstruct the ad overlay but are essential for playback need to