loliball/media3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove old TODOs and reassign another TODO.

Browse Source 
* The AdvancedFrameProcessor calls use() in updateProgramAndDraw().
* The AdvancedFrameProcessor has the same input and output dimensions.

PiperOrigin-RevId: 437231350
This commit is contained in:
hschlueter 2022-03-25 13:22:22 +00:00 committed by Ian Baker
parent dc4dbe6a40
commit 5f573ad3ad
3 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/common/src/main/java/androidx/media3/common/util/GlProgram.java
View File

@ -147,8 +147,6 @@ public final class GlProgram {
* <p>Call this in the rendering loop to switch between different programs. * <p>Call this in the rendering loop to switch between different programs.
*/ */
public void use() { public void use() {
// TODO(b/214975934): When multiple GL programs are supported by Transformer, make sure
// to call use() to switch between programs.
GLES20.glUseProgram(programId); GLES20.glUseProgram(programId);
GlUtil.checkGlError(); GlUtil.checkGlError();
} }

2
libraries/transformer/src/androidTest/java/androidx/media3/transformer/AdvancedFrameProcessorPixelTest.java
View File

@ -58,8 +58,6 @@ public final class AdvancedFrameProcessorPixelTest {
private @MonotonicNonNull GlFrameProcessor advancedFrameProcessor; private @MonotonicNonNull GlFrameProcessor advancedFrameProcessor;
private int inputTexId; private int inputTexId;
private int outputTexId; private int outputTexId;
// TODO(b/214975934): Once the frame processors are allowed to have different input and output
// dimensions, get the output dimensions from the frame processor.
private int width; private int width;
private int height; private int height;

2
libraries/transformer/src/main/java/androidx/media3/transformer/GlFrameProcessor.java
View File

@ -34,7 +34,7 @@ import java.io.IOException;
*/ */
@UnstableApi @UnstableApi
public interface GlFrameProcessor { public interface GlFrameProcessor {
// TODO(b/214975934): Investigate whether all configuration can be moved to initialize by // TODO(b/213313666): Investigate whether all configuration can be moved to initialize by
// using a placeholder surface until the encoder surface is known. If so, convert // using a placeholder surface until the encoder surface is known. If so, convert
// configureOutputSize to a simple getter. // configureOutputSize to a simple getter.